revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-11 07:11:03 +01:00
Code Issues Releases Wiki Activity

Various improvements for ArcanistClosureLinter

Browse source 
Summary: WIP

Test Plan: WIP

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11207
This commit is contained in:
Joshua Spence 2015-01-05 07:43:55 +11:00
parent 9e6f876a68
commit eb3129408b
1 changed files with 15 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/lint/linter/ArcanistClosureLinter.php
View file

@ -1,7 +1,7 @@
<?php <?php
/** /**
* Uses gJSLint to detect errors and potential problems in JavaScript code. * Uses `gjslint` to detect errors and potential problems in JavaScript code.
*/ */
final class ArcanistClosureLinter extends ArcanistExternalLinter { final class ArcanistClosureLinter extends ArcanistExternalLinter {
@ -14,11 +14,11 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter {
} }
public function getInfoDescription() { public function getInfoDescription() {
return pht("Uses Google's Closure Linter to check Javascript code."); return pht("Uses Google's Closure Linter to check JavaScript code.");
} }
public function getLinterName() { public function getLinterName() {
return 'Closure Linter'; return 'GJSLINT';
} }
public function getLinterConfigurationName() { public function getLinterConfigurationName() {
@ -31,8 +31,10 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter {
public function getInstallInstructions() { public function getInstallInstructions() {
return pht( return pht(
'Install gJSLint using `sudo easy_install http://closure-linter'. 'Install %s using `%s`.',
'.googlecode.com/files/closure_linter-latest.tar.gz`'); 'gjslint',
'sudo easy_install http://closure-linter.googlecode.com/'.
'files/closure_linter-latest.tar.gz');
} }
public function shouldExpectCommandErrors() { public function shouldExpectCommandErrors() {
@ -44,32 +46,21 @@ final class ArcanistClosureLinter extends ArcanistExternalLinter {
} }
protected function parseLinterOutput($path, $err, $stdout, $stderr) { protected function parseLinterOutput($path, $err, $stdout, $stderr) {
// Each line looks like this:
// Line 46, E:0110: Line too long (87 characters).
$regex = '/^Line (\d+), (E:\d+): (.*)/';
$severity_code = ArcanistLintSeverity::SEVERITY_ERROR;
$lines = phutil_split_lines($stdout, false); $lines = phutil_split_lines($stdout, false);
$messages = array(); $messages = array();
foreach ($lines as $line) { foreach ($lines as $line) {
$line = trim($line);
$matches = null; $matches = null;
if (!preg_match($regex, $line, $matches)) { if (!preg_match('/^Line (\d+), E:(\d+): (.*)/', $line, $matches)) {
continue; continue;
} }
foreach ($matches as $key => $match) {
$matches[$key] = trim($match);
}
$message = new ArcanistLintMessage();
$message->setPath($path);
$message->setLine($matches[1]);
$message->setName($matches[2]);
$message->setCode($this->getLinterName());
$message->setDescription($matches[3]);
$message->setSeverity($severity_code);
$message = id(new ArcanistLintMessage())
->setPath($path)
->setLine($matches[1])
->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR)
->setCode($this->getLinterName().$matches[2])
->setDescription($matches[3]);
$messages[] = $message; $messages[] = $message;
} }