From eb58ed1b8b3b8da06eb4668b6364f8207a824ca8 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 14 Mar 2011 17:39:12 -0700 Subject: [PATCH] asukhachev's patch for 'arc amend' not being overeager. --- src/workflow/amend/ArcanistAmendWorkflow.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/workflow/amend/ArcanistAmendWorkflow.php b/src/workflow/amend/ArcanistAmendWorkflow.php index a8a49d44..177f5cd5 100644 --- a/src/workflow/amend/ArcanistAmendWorkflow.php +++ b/src/workflow/amend/ArcanistAmendWorkflow.php @@ -130,9 +130,15 @@ EOTEXT $mark_workflow->run(); } - echo phutil_console_wrap( - "You may now push this commit upstream, as appropriate (e.g. with ". - "'git push', or 'git svn dcommit', or by printing and faxing it).\n"); + $remote_message = ArcanistDifferentialCommitMessage::newFromRawCorpus( + $message); + $remote_message->pullDataFromConduit($conduit); + if ($remote_message->getFieldValue('reviewedByGUIDs') || + $remote_message->getFieldValue('reviewedByPHIDs')) { + echo phutil_console_wrap( + "You may now push this commit upstream, as appropriate (e.g. with ". + "'git push', or 'git svn dcommit', or by printing and faxing it).\n"); + } } return 0;