revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-03-15 22:04:56 +01:00
Code Issues Releases Wiki Activity

Add explicit cast to ArcanistUnitConsoleRenderer unit test

Browse source 
Summary:
D25848 was incomplete. `$seconds` itself is not an int but a float.
Thus explicitly also cast `$seconds` to int to avoid an error in PHP 8.1 and later.

Test Plan: Run `bin/arc unit --everything`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #arcanist

Differential Revision: https://we.phorge.it/D25856
This commit is contained in:
Andre Klapper 2024-12-19 11:35:14 +01:00
parent f0176263a7
commit ec68f53ba2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/unit/renderer/ArcanistUnitConsoleRenderer.php
View file

@ -83,7 +83,7 @@ final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer {
private function formatTime($seconds) {
if ($seconds >= 60) {
$minutes = (int)floor($seconds / 60);
return pht('%dm%02ds', $minutes, round($seconds % 60));
return pht('%dm%02ds', $minutes, round((int)$seconds % 60));
}
if ($seconds >= 1) {