revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Avoid double indenting in console wrapping

Browse source 
Summary:
D2016 changed the behavior of `phutil_console_wrap()`.
The new behavior is better so I am fixing callsites instead of the function.

Test Plan:
  arc help help

Verify that the options descriptions is not indented with 28 spaces.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2047
This commit is contained in:
vrana 2012-03-28 21:38:31 -07:00
parent 070e963d1c
commit edb6a38389
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/lint/renderer/ArcanistLintRenderer.php
View file

@ -45,8 +45,7 @@ final class ArcanistLintRenderer {
$description = phutil_console_wrap($message->getDescription(), 4); $description = phutil_console_wrap($message->getDescription(), 4);
$text[] = phutil_console_format( $text[] = phutil_console_format(
" **<bg:{$color}> %s </bg>** (%s) __%s__\n". " **<bg:{$color}> %s </bg>** (%s) __%s__\n%s\n",
" %s\n",
$severity, $severity,
$code, $code,
$name, $name,

2
src/workflow/diff/ArcanistDiffWorkflow.php
View file

@ -624,7 +624,7 @@ EOTEXT
"\n\n". "\n\n".
"Modified 'svn:externals' files:". "Modified 'svn:externals' files:".
"\n\n". "\n\n".
' '.phutil_console_wrap(implode("\n", $warn_externals), 8)); phutil_console_wrap(implode("\n", $warn_externals), 8));
$prompt = "Generate a diff (with just local changes) anyway?"; $prompt = "Generate a diff (with just local changes) anyway?";
if (!phutil_console_confirm($prompt)) { if (!phutil_console_confirm($prompt)) {
throw new ArcanistUserAbortException(); throw new ArcanistUserAbortException();

2
src/workflow/help/ArcanistHelpWorkflow.php
View file

@ -138,7 +138,7 @@ EOTEXT
$docs = 'This option is not documented.'; $docs = 'This option is not documented.';
} }
$docs = phutil_console_wrap($docs, 14); $docs = phutil_console_wrap($docs, 14);
$optref[] = " {$docs}\n"; $optref[] = "{$docs}\n";
} }
if ($optref) { if ($optref) {
$optref = implode("\n", $optref); $optref = implode("\n", $optref);