From edd85a0e9db4bc362cf388be356facc07c3456e1 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Sat, 10 May 2014 01:55:47 -0700
Subject: [PATCH] Modernize `ArcanistMergeConflictLinter`.

Summary: The only real change here is adding a `getLinterConfigurationName` method so that this linter can be used with an `.arclint` file. Everything else is just some minor tidying.

Test Plan: N/A

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9039
---
 .../linter/ArcanistMergeConflictLinter.php     | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/lint/linter/ArcanistMergeConflictLinter.php b/src/lint/linter/ArcanistMergeConflictLinter.php
index 93c4d61b..1b4d8d68 100644
--- a/src/lint/linter/ArcanistMergeConflictLinter.php
+++ b/src/lint/linter/ArcanistMergeConflictLinter.php
@@ -8,6 +8,14 @@
 final class ArcanistMergeConflictLinter extends ArcanistLinter {
   const LINT_MERGECONFLICT = 1;
 
+  public function getLinterName() {
+    return 'MERGECONFLICT';
+  }
+
+  public function getLinterConfigurationName() {
+    return 'merge-conflict';
+  }
+
   public function willLintPaths(array $paths) {
     return;
   }
@@ -23,24 +31,20 @@ final class ArcanistMergeConflictLinter extends ArcanistLinter {
           $lineno + 1,
           0,
           self::LINT_MERGECONFLICT,
-          "This syntax indicates there is an unresolved merge conflict.");
+          'This syntax indicates there is an unresolved merge conflict.');
       }
     }
   }
 
-  public function getLinterName() {
-    return "MERGECONFLICT";
-  }
-
   public function getLintSeverityMap() {
     return array(
-      self::LINT_MERGECONFLICT => ArcanistLintSeverity::SEVERITY_ERROR
+      self::LINT_MERGECONFLICT => ArcanistLintSeverity::SEVERITY_ERROR,
     );
   }
 
   public function getLintNameMap() {
     return array(
-      self::LINT_MERGECONFLICT => "Unresolved merge conflict"
+      self::LINT_MERGECONFLICT => 'Unresolved merge conflict',
     );
   }
 }