From ee21b3c66186dfb152682fa6e1f1494ea80213e6 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Sun, 4 Mar 2012 03:16:45 -0800
Subject: [PATCH] Simplify `arc help`, add `arc help --full`

Summary:
`arc help` currently prints more than 500 lines and it is hardly usable without ##> arc.help##, ##| less##, ##| grep##, ##| wc -l## or such.
It is even worse with custom commands and options.

This diff changes `arc help` to only list commands with no description (under 100 lines).
It also adds `arc help --full` which maintains the original behavior.
It doesn't change `arc help <command>`.

NOTE: BC break on different levels.

Test Plan:
  arc help
  arc help --full
  arc help help
  arc help lint

Reviewers: epriestley

Reviewed By: epriestley

CC: nh, aran, epriestley

Differential Revision: https://secure.phabricator.com/D1769
---
 src/workflow/help/ArcanistHelpWorkflow.php | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/workflow/help/ArcanistHelpWorkflow.php b/src/workflow/help/ArcanistHelpWorkflow.php
index 2c0273a7..2b0cf99c 100644
--- a/src/workflow/help/ArcanistHelpWorkflow.php
+++ b/src/workflow/help/ArcanistHelpWorkflow.php
@@ -160,16 +160,13 @@ EOTEXT
     }
 
     $self = 'arc';
-    $description = ($this->getArgument('full') ?
-      "This help file provides a detailed command reference." :
-      "Run 'arc help --full' to get detailed command reference.");
     echo phutil_console_format(<<<EOTEXT
 **NAME**
       **{$self}** - arcanist, a code review and revision management utility
 
 **SYNOPSIS**
       **{$self}** __command__ [__options__] [__args__]
-      {$description}
+      This help file provides a detailed command reference.
 
 **COMMAND REFERENCE**
 
@@ -180,6 +177,7 @@ EOTEXT
     );
 
     if (!$this->getArgument('full')) {
+      echo "Run 'arc help --full' to get commands and options descriptions.\n";
       return;
     }