From f06eea0d848489f68f9b197a77d5d5d84031e589 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Fri, 19 Jun 2015 13:15:43 +1000 Subject: [PATCH] Fix arcanist shell completion Summary: Fixes T8560. Test Plan: Ran `arc shell-complete` outside of a working copy. Reviewers: avivey, #blessed_reviewers, epriestley Reviewed By: avivey, #blessed_reviewers, epriestley Subscribers: avivey, epriestley, Korvin Maniphest Tasks: T8560 Differential Revision: https://secure.phabricator.com/D13338 --- src/workflow/ArcanistShellCompleteWorkflow.php | 3 +++ src/workflow/ArcanistWorkflow.php | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/workflow/ArcanistShellCompleteWorkflow.php b/src/workflow/ArcanistShellCompleteWorkflow.php index 0a933506..6e6c8319 100644 --- a/src/workflow/ArcanistShellCompleteWorkflow.php +++ b/src/workflow/ArcanistShellCompleteWorkflow.php @@ -84,6 +84,9 @@ EOTEXT continue; } + $workflow->setArcanistConfiguration($this->getArcanistConfiguration()); + $workflow->setConfigurationManager($this->getConfigurationManager()); + if ($vcs || $workflow->requiresWorkingCopy()) { $supported_vcs = $workflow->getSupportedRevisionControlSystems(); if (!in_array($vcs, $supported_vcs)) { diff --git a/src/workflow/ArcanistWorkflow.php b/src/workflow/ArcanistWorkflow.php index 5689b7ab..ca47c8ca 100644 --- a/src/workflow/ArcanistWorkflow.php +++ b/src/workflow/ArcanistWorkflow.php @@ -53,8 +53,8 @@ abstract class ArcanistWorkflow extends Phobject { private $repositoryAPI; private $configurationManager; private $workingCopy; - private $arguments; - private $passedArguments; + private $arguments = array(); + private $passedArguments = array(); private $command; private $stashed;