revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 00:02:40 +01:00
Code Issues Releases Wiki Activity

Remove deprecated support for specifying flags as a string

Browse source 
Summary: It should be safe to remove this now.

Test Plan: `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11714
This commit is contained in:
Joshua Spence 2015-02-10 06:55:27 +11:00
parent bf7b32fe2c
commit f13b7d73d0
1 changed files with 5 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/lint/linter/ArcanistExternalLinter.php
View file

@ -141,8 +141,8 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
* @return this
* @task bin
*/
final public function setFlags($flags) {
$this->flags = (array)$flags;
final public function setFlags(array $flags) {
$this->flags = $flags;
return $this;
}
@ -337,21 +337,9 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
* @task exec
*/
final protected function getCommandFlags() {
$mandatory_flags = $this->getMandatoryFlags();
if (!is_array($mandatory_flags)) {
phutil_deprecated(
'String support for flags.', 'You should use list<string> instead.');
$mandatory_flags = (array) $mandatory_flags;
}
$flags = nonempty($this->flags, $this->getDefaultFlags());
if (!is_array($flags)) {
phutil_deprecated(
'String support for flags.', 'You should use list<string> instead.');
$flags = (array) $flags;
}
return array_merge($mandatory_flags, $flags);
return array_merge(
$this->getMandatoryFlags(),
nonempty($this->flags, $this->getDefaultFlags()));
}
public function getCacheVersion() {
@ -508,12 +496,6 @@ abstract class ArcanistExternalLinter extends ArcanistFutureLinter {
throw new Exception(
pht('None of the configured binaries can be located.'));
case 'flags':
if (!is_array($value)) {
phutil_deprecated(
'String support for flags.',
'You should use list<string> instead.');
$value = (array) $value;
}
$this->setFlags($value);
return;
}