Update puppet-lint linter

Summary: Update the `puppet-lint` linter to support the latest version (v1.0.1). This version allows a custom configuration file to be passed via `--config`, which brings this linter into line with other linters.

Test Plan: Update test cases to pass.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10384

src/lint/linter/ArcanistPuppetLintLinter.php

@@ -5,12 +5,14 @@
  */
 final class ArcanistPuppetLintLinter extends ArcanistExternalLinter {
 
+  private $config;
+
   public function getInfoURI() {
     return 'http://puppet-lint.com/';
   }
 
   public function getInfoName() {
-    return pht('puppet-lint');
+    return 'puppet-lint';
   }
 
   public function getInfoDescription() {
@@ -64,6 +66,37 @@ final class ArcanistPuppetLintLinter extends ArcanistExternalLinter {
       '%{message}'))));
   }
 
+  public function getLinterConfigurationOptions() {
+    $options = array(
+      'puppet-lint.config' => array(
+        'type' => 'optional string',
+        'help' => pht('Pass in a custom configuration file path.'),
+      ),
+    );
+
+    return $options + parent::getLinterConfigurationOptions();
+  }
+
+  public function setLinterConfigurationValue($key, $value) {
+    switch ($key) {
+      case 'puppet-lint.config':
+        $this->config = $value;
+        return;
+    }
+
+    return parent::setLinterConfigurationValue($key, $value);
+  }
+
+  protected function getDefaultFlags() {
+    $options = array();
+
+    if ($this->config) {
+      $options[] = '--config='.$this->config;
+    }
+
+    return $options;
+  }
+
   protected function parseLinterOutput($path, $err, $stdout, $stderr) {
     $lines = phutil_split_lines($stdout, false);
 

src/lint/linter/__tests__/puppet-lint/arrow_alignment.lint-test

@@ -3,4 +3,4 @@ exec { 'test':
   refreshonly => true,
 }
 ~~~~~~~~~~
-warning:3:15
+warning:2:13