1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-07-22 11:56:15 +02:00

Fix text lint issues

Summary: Ref T5105. This is a proof-of-concept for D11458.

Test Plan: `arc lint --everything`

Reviewers: chad, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T5105

Differential Revision: https://secure.phabricator.com/D11640
This commit is contained in:
Joshua Spence 2015-04-07 18:09:26 +10:00
parent 3a5ffdc2fd
commit f2a3fdf5e3
22 changed files with 84 additions and 65 deletions

View file

@ -1,7 +1,6 @@
{
"exclude": [
"(^externals/)",
"(\\.lint-test$)"
"(^externals/)"
],
"linters": {
"chmod": {
@ -41,19 +40,7 @@
"exclude": "(^resources/spelling/.*\\.json$)"
},
"text": {
"type": "text",
"exclude": [
"(^\\.arclint$)"
]
},
"text-without-length": {
"type": "text",
"severity": {
"3": "disabled"
},
"include": [
"(^\\.arclint$)"
]
"type": "text"
},
"xhpast": {
"type": "xhpast",

View file

@ -3,24 +3,50 @@
[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
max_line_length = 80
[src/lint/linter/__tests__/**.lint-test]
indent_style =
end_of_line =
max_line_length =
trim_trailing_whitespace =
[src/parser/__tests__/bundle/*]
trim_trailing_whitespace = false
insert_final_newline = false
[src/parser/__tests__/diff/*.{git,hg,svn,u}diff]
[src/parser/__tests__/diff/*.{git,hg,rcs,svn,u}diff]
indent_style =
trim_trailing_whitespace = false
insert_final_newline = false
max_line_length =
[src/parser/__tests__/patches/*.{git,hg,rcs,svn,u}patch]
indent_style =
trim_trailing_whitespace = false
max_line_length =
[src/parser/__tests__/patches/*.gitpatch]
end_of_line =
[src/parser/__tests__/**/*.txt]
max_line_length =
[src/repository/parser/__tests__/mercurial/*.txt]
trim_trailing_whitespace = false
insert_final_newline = false
max_line_length =
[src/unit/parser/__tests__/testresults/go.*]
indent_style =
[src/unit/parser/__tests__/testresults/xunit.*]
max_line_length =
[externals/**]
; Use editor default (possible autodetection).
indent_style =
indent_size =
trim_trailing_whitespace = false

View file

@ -1,4 +1,3 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

View file

@ -166,7 +166,11 @@ def main(stdscr):
h = height / 10
for x in range(1, width / 7 - 1):
for y in range(1, 7):
entities.append(Block(x * 7, y * h + x / 2 % 2, 7, h, colors[y - 1]))
entities.append(Block(x * 7,
y * h + x / 2 % 2,
7,
h,
colors[y - 1]))
while True:
while select.select([ sys.stdin ], [], [], 0)[0]:

View file

@ -17,4 +17,4 @@ error:2:
error:4:
error:5:
error:7:
error:9:
error:9:

View file

@ -8,4 +8,4 @@ function f() {
~~~~~~~~~~
warning:3:8
error:7:1
error:7:1

View file

@ -82,7 +82,7 @@ p + h1 {
background: -webkit-gradient(linear, left top, left bottom, from(red), to(blue));
margin: ;
.nested-multiple {
multiple-semi-colons: yes;;;;;;
multiple-semi-colons: yes;;;;;;
};
filter: alpha(opacity=100);
width: auto\9;

View file

@ -1,4 +1,3 @@
// simple array/list:
.multiunit {

View file

@ -62,11 +62,11 @@
format-single-quoted: %('hello %s', "single world");
format-escaped-string: %(~"hello %s", "escaped world");
eformat: e(%("rgb(%d, %d, %d)", @r, 128, 64));
unitless: unit(12px);
unit: unit((13px + 1px), em);
unitpercentage: unit(100, %);
get-unit: get-unit(10px);
get-unit-empty: get-unit(10);
@ -118,7 +118,7 @@
fade-out: fadeOut(red, 5%); // support fadeOut and fadeout
fade-in: fadein(fadeout(red, 10%), 5%);
hsv: hsv(5, 50%, 30%);
hsva: hsva(3, 50%, 30%, 0.2);

View file

@ -1,4 +1,3 @@
// For now, variables can't be declared inside @media blocks.
@var: 42;

View file

@ -41,9 +41,9 @@ a {
.qux & {
display: inline;
}
.qux& {
display: inline-block;
}
.qux& {
display: inline-block;
}
.qux & .biz {
display: none;
}
@ -123,7 +123,7 @@ a {
}
@num: 3;
:nth-child(@{num}) {
selector: interpolated;
selector: interpolated;
}
.test {
&:nth-child(odd):not(:nth-child(3)) {

View file

@ -3,4 +3,4 @@
deprecated_function();
modern_function();
~~~~~~~~~~
warning:3:1
warning:3:1

View file

@ -9,4 +9,4 @@ final class C { }
*/
class D { }
~~~~~~~~~~
warning:3:7
warning:3:7

View file

@ -10,4 +10,4 @@ error:2:1
error:3:1
error:3:14
error:4:3
error:6:3
error:6:3

View file

@ -1,5 +1,5 @@
The quick brown fox
jumps over the lazy dog.
The quick brown fox
jumps over the lazy dog.
~~~~~~~~~~
error:1:1
~~~~~~~~~~

View file

@ -2,4 +2,4 @@
This shouldn't fatal the parser.
~~~~~~~~~~
error:1:10
error:1:10

View file

@ -5,4 +5,4 @@ strtoupper(33 * exit - 6);
~~~~~~~~~~
error:3:1
warning:3:6
error:4:17
error:4:17

View file

@ -6,4 +6,4 @@ final class Platypus {
}
~~~~~~~~~~
error:2:13 XHP19 Class-Filename Mismatch
error:3:19
error:3:19

View file

@ -5,4 +5,9 @@ chroot('/tmp');
error:3:1
~~~~~~~~~~
~~~~~~~~~~
{"config": {"xhpast.php-version": "5.2.3", "xhpast.php-version.windows": "5.3.0"}}
{
"config": {
"xhpast.php-version": "5.2.3",
"xhpast.php-version.windows": "5.3.0"
}
}

View file

@ -1,13 +1,13 @@
Index: Database/tables/dbo.Account.sql
===================================================================
--- Database/tables/dbo.Account.sql (revision 1587)
+++ Database/tables/dbo.Account.sql (working copy)
@@ -23,6 +23,8 @@
GO
CREATE CLUSTERED INDEX IX_Account ON [Account] ([CreationDateTime])
GO
+ALTER TABLE [dbo].[Account] ADD CONSTRAINT [UK_Account_APIKey] UNIQUE ([APIKey])
+GO
ALTER TABLE [dbo].[Account] ADD CONSTRAINT [DF_Account_AccountId] DEFAULT (newid()) FOR [AccountId]
GO
ALTER TABLE [dbo].[Account] ADD CONSTRAINT [DF_Account_CreationDateTime] DEFAULT (getutcdate()) FOR [CreationDateTime]
Index: Database/tables/dbo.Account.sql
===================================================================
--- Database/tables/dbo.Account.sql (revision 1587)
+++ Database/tables/dbo.Account.sql (working copy)
@@ -23,6 +23,8 @@
GO
CREATE CLUSTERED INDEX IX_Account ON [Account] ([CreationDateTime])
GO
+ALTER TABLE [dbo].[Account] ADD CONSTRAINT [UK_Account_APIKey] UNIQUE ([APIKey])
+GO
ALTER TABLE [dbo].[Account] ADD CONSTRAINT [DF_Account_AccountId] DEFAULT (newid()) FOR [AccountId]
GO
ALTER TABLE [dbo].[Account] ADD CONSTRAINT [DF_Account_CreationDateTime] DEFAULT (getutcdate()) FOR [CreationDateTime]

View file

@ -1,11 +1,11 @@
Index: .arcconfig
===================================================================
--- .arcconfig (revision 1957)
+++ .arcconfig (working copy)
Property changes on: .arcconfig
___________________________________________________________________
Added: herp
## -0,0 +1 ##
+derp
Index: .arcconfig
===================================================================
--- .arcconfig (revision 1957)
+++ .arcconfig (working copy)
Property changes on: .arcconfig
___________________________________________________________________
Added: herp
## -0,0 +1 ##
+derp
\ No newline at end of property

View file

@ -1 +1 @@
<?xml version="1.0" encoding="utf-8"?><testsuite name="" errors="0" failures="0" skips="0" tests="0" time="0.001" ></testsuite>
<?xml version="1.0" encoding="utf-8"?><testsuite name="" errors="0" failures="0" skips="0" tests="0" time="0.001" ></testsuite>