Add tests for git submodules, based on current behavior

Summary:
This adds tests that detail the current behavior of `arc` in
the presence of `git` submodules.

Test Plan: No behavior change; wrote the tests such that they pass.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D18841

src/repository/api/__tests__/ArcanistRepositoryAPIStateTestCase.php

@@ -5,6 +5,8 @@ final class ArcanistRepositoryAPIStateTestCase extends PhutilTestCase {
   public function testGitStateParsing() {
     if (Filesystem::binaryExists('git')) {
       $this->parseState('git_basic.git.tgz');
+      $this->parseState('git_submodules_dirty.git.tgz');
+      $this->parseState('git_submodules_staged.git.tgz');
     } else {
       $this->assertSkipped(pht('Git is not installed'));
     }
@@ -99,6 +101,28 @@ final class ArcanistRepositoryAPIStateTestCase extends PhutilTestCase {
         );
         $this->assertEqual($expect_range, $api->getCommitRangeStatus());
         break;
+      case 'git_submodules_dirty.git.tgz':
+        $expect_uncommitted = array(
+          '.gitmodules'           => $f_mod | $f_uns | $f_unc,
+          'added/'                => $f_unt,
+          'deleted'               => $f_del | $f_uns | $f_unc,
+          'modified-commit'       => $f_mod | $f_uns | $f_unc,
+          'modified-commit-dirty' => $f_mod | $f_uns | $f_unc,
+          'modified-dirty'        => $f_ext | $f_uns | $f_unc,
+        );
+        $this->assertEqual($expect_uncommitted, $api->getUncommittedStatus());
+        break;
+      case 'git_submodules_staged.git.tgz':
+        $expect_uncommitted = array(
+          '.gitmodules'           => $f_mod | $f_uns | $f_unc,
+          'added'                 => $f_add | $f_unc,
+          'deleted'               => $f_del | $f_unc,
+          'modified-commit'       => $f_mod | $f_unc,
+          'modified-commit-dirty' => $f_mod | $f_uns | $f_unc,
+          'modified-dirty'        => $f_ext | $f_uns | $f_unc,
+        );
+        $this->assertEqual($expect_uncommitted, $api->getUncommittedStatus());
+        break;
       case 'hg_basic.hg.tgz':
         $expect_uncommitted = array(
           'UNCOMMITTED' => $f_mod | $f_unc,