revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
Code Issues Releases Wiki Activity

Update golint install instructions

Browse source 
Summary:
These are the instructions from https://github.com/golang/lint.

The fetch location changed to `golang.org/x/lint/golint` from `github.com/golang/lint/golint`.
`-u` tells go to update the package and its deps if they exist.
`-u` Shouldn't strictly be necessary, but figured we might as well follow the instructions from `golint`.

Test Plan:
Enable golint without having it installed.
Ensure that the install instructions now show the new location.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D21552
This commit is contained in:
Vihang Mehta 2021-02-10 10:03:28 -08:00 committed by epriestley
parent 239ad5c55d
commit f501f85eb8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lint/linter/ArcanistGoLintLinter.php
View file

@ -29,7 +29,7 @@ final class ArcanistGoLintLinter extends ArcanistExternalLinter {
public function getInstallInstructions() { public function getInstallInstructions() {
return pht( return pht(
'Install Golint using `%s`.', 'Install Golint using `%s`.',
'go get github.com/golang/lint/golint'); 'go get -u golang.org/x/lint/golint');
} }
public function shouldExpectCommandErrors() { public function shouldExpectCommandErrors() {