From f64eb04300b4aaed75d2eda604322db8b4a2329e Mon Sep 17 00:00:00 2001
From: Jessica Clarke <jrtc27@jrtc27.com>
Date: Mon, 11 Jan 2021 04:50:37 +0000
Subject: [PATCH] Fix
 PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8

Summary:
PHP 8 deprecates openssl_free_key as the key is automatically freed, so
silence the warning in PhutilOAuth1Future::signString.

Test Plan: Ran arc lint --everything

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21502
---
 src/future/oauth/PhutilOAuth1Future.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/future/oauth/PhutilOAuth1Future.php b/src/future/oauth/PhutilOAuth1Future.php
index 084ae6f9..8edd6c26 100644
--- a/src/future/oauth/PhutilOAuth1Future.php
+++ b/src/future/oauth/PhutilOAuth1Future.php
@@ -268,7 +268,8 @@ final class PhutilOAuth1Future extends FutureProxy {
           throw new Exception(pht('%s failed!', 'openssl_sign()'));
         }
 
-        openssl_free_key($pkey);
+        // Deprecated in PHP 8; key is automatically freed.
+        @openssl_free_key($pkey);
 
         return base64_encode($signature);
       case 'PLAINTEXT':