From f7fcf31c7e23475e345cb3cd4abf0474ba6fd9cf Mon Sep 17 00:00:00 2001 From: Pppery Date: Fri, 7 Jun 2024 12:52:04 -0400 Subject: [PATCH] Remove PhutilPhtTestCase::getDateTranslations() Summary: See my comment at T15815#17864. I don't think the translation extractor has any consumers other than the downstream translations extension, and I'd prefer to handle this issue there rather than upstream. Test Plan: Read the code. Reviewers: O1 Blessed Committers, aklapper Reviewed By: O1 Blessed Committers, aklapper Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25684 --- .../__tests__/PhutilPhtTestCase.php | 69 ------------------- 1 file changed, 69 deletions(-) diff --git a/src/internationalization/__tests__/PhutilPhtTestCase.php b/src/internationalization/__tests__/PhutilPhtTestCase.php index fed12b1d..e10ed35a 100644 --- a/src/internationalization/__tests__/PhutilPhtTestCase.php +++ b/src/internationalization/__tests__/PhutilPhtTestCase.php @@ -29,73 +29,4 @@ final class PhutilPhtTestCase extends PhutilTestCase { $this->assertEqual('5 piv', pht('%d beer(s)', 5)); } - - public function getDateTranslations() { - // The only purpose of this function is to provide a static list of - // translations which can come from PhutilTranslator::translateDate() to - // allow translation extractor getting them. - return array( - 'D' => array( - pht('Sun'), - pht('Mon'), - pht('Tue'), - pht('Wed'), - pht('Thu'), - pht('Fri'), - pht('Sat'), - ), - 'l' => array( - pht('Sunday'), - pht('Monday'), - pht('Tuesday'), - pht('Wednesday'), - pht('Thursday'), - pht('Friday'), - pht('Saturday'), - ), - 'S' => array( - pht('st'), - pht('nd'), - pht('rd'), - pht('th'), - ), - 'F' => array( - pht('January'), - pht('February'), - pht('March'), - pht('April'), - pht('May'), - pht('June'), - pht('July'), - pht('August'), - pht('September'), - pht('October'), - pht('November'), - pht('December'), - ), - 'M' => array( - pht('Jan'), - pht('Feb'), - pht('Mar'), - pht('Apr'), - pht('May'), - pht('Jun'), - pht('Jul'), - pht('Aug'), - pht('Sep'), - pht('Oct'), - pht('Nov'), - pht('Dec'), - ), - 'a' => array( - pht('am'), - pht('pm'), - ), - 'A' => array( - pht('AM'), - pht('PM'), - ), - ); - } - }