revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-21 22:32:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]
```

Refs T15926

Test Plan: Either read the code, or probably run something like `arc unit` on D25797?

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15926

Differential Revision: https://we.phorge.it/D25800
This commit is contained in:
Andre Klapper 2024-08-23 13:08:17 +02:00
parent 995072b31f
commit f974927377
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/parser/xhpast/__tests__/PHPASTParserTestCase.php
View file

@ -82,7 +82,7 @@ final class PHPASTParserTestCase extends PhutilTestCase {
case 'pass': case 'pass':
$this->assertEqual(0, $err, pht('Exit code for "%s".', $name)); $this->assertEqual(0, $err, pht('Exit code for "%s".', $name));
if (!strlen($expect)) { if (!phutil_nonempty_string($expect)) {
// If there's no "expect" data in the test case, that's OK. // If there's no "expect" data in the test case, that's OK.
break; break;
} }