revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Remove deprecated "base" classes

Browse source 
Summary: Ref T5655. After D9983, `ArcanistBaseWorkflow` and `ArcanistBaseUnitTestEngine` are deprecated.

Test Plan: Wait a sufficient amount of time before landing this.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D10004
This commit is contained in:
Joshua Spence 2015-05-16 10:15:39 +10:00
parent e1a051a033
commit f9cefb7e2d
5 changed files with 0 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/__phutil_library_map__.php
View file

@ -15,8 +15,6 @@ phutil_register_library_map(array(
'ArcanistBackoutWorkflow' => 'workflow/ArcanistBackoutWorkflow.php', 'ArcanistBackoutWorkflow' => 'workflow/ArcanistBackoutWorkflow.php',
'ArcanistBaseCommitParser' => 'parser/ArcanistBaseCommitParser.php', 'ArcanistBaseCommitParser' => 'parser/ArcanistBaseCommitParser.php',
'ArcanistBaseCommitParserTestCase' => 'parser/__tests__/ArcanistBaseCommitParserTestCase.php', 'ArcanistBaseCommitParserTestCase' => 'parser/__tests__/ArcanistBaseCommitParserTestCase.php',
'ArcanistBaseUnitTestEngine' => 'unit/engine/ArcanistBaseUnitTestEngine.php',
'ArcanistBaseWorkflow' => 'workflow/ArcanistBaseWorkflow.php',
'ArcanistBaseXHPASTLinter' => 'lint/linter/ArcanistBaseXHPASTLinter.php', 'ArcanistBaseXHPASTLinter' => 'lint/linter/ArcanistBaseXHPASTLinter.php',
'ArcanistBookmarkWorkflow' => 'workflow/ArcanistBookmarkWorkflow.php', 'ArcanistBookmarkWorkflow' => 'workflow/ArcanistBookmarkWorkflow.php',
'ArcanistBranchWorkflow' => 'workflow/ArcanistBranchWorkflow.php', 'ArcanistBranchWorkflow' => 'workflow/ArcanistBranchWorkflow.php',
@ -220,8 +218,6 @@ phutil_register_library_map(array(
'ArcanistAnoidWorkflow' => 'ArcanistWorkflow', 'ArcanistAnoidWorkflow' => 'ArcanistWorkflow',
'ArcanistBackoutWorkflow' => 'ArcanistWorkflow', 'ArcanistBackoutWorkflow' => 'ArcanistWorkflow',
'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase', 'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
'ArcanistBaseUnitTestEngine' => 'ArcanistUnitTestEngine',
'ArcanistBaseWorkflow' => 'ArcanistWorkflow',
'ArcanistBaseXHPASTLinter' => 'ArcanistFutureLinter', 'ArcanistBaseXHPASTLinter' => 'ArcanistFutureLinter',
'ArcanistBookmarkWorkflow' => 'ArcanistFeatureWorkflow', 'ArcanistBookmarkWorkflow' => 'ArcanistFeatureWorkflow',
'ArcanistBranchWorkflow' => 'ArcanistFeatureWorkflow', 'ArcanistBranchWorkflow' => 'ArcanistFeatureWorkflow',

7
src/unit/engine/ArcanistBaseUnitTestEngine.php
View file

@ -1,7 +0,0 @@
<?php
/**
* NOTE: Do not extend from this class, extend from
* @{class:ArcanistUnitTestEngine} instead.
*/
abstract class ArcanistBaseUnitTestEngine extends ArcanistUnitTestEngine {}

7
src/unit/engine/ArcanistUnitTestEngine.php
View file

@ -51,13 +51,6 @@ abstract class ArcanistUnitTestEngine {
final public function setWorkingCopy( final public function setWorkingCopy(
ArcanistWorkingCopyIdentity $working_copy) { ArcanistWorkingCopyIdentity $working_copy) {
// TODO: Remove this once ArcanistBaseUnitTestEngine is gone.
if ($this instanceof ArcanistBaseUnitTestEngine) {
phutil_deprecated(
'ArcanistBaseUnitTestEngine',
pht('You should extend from `%s` instead.', __CLASS__));
}
$this->workingCopy = $working_copy; $this->workingCopy = $working_copy;
return $this; return $this;
} }

7
src/workflow/ArcanistBaseWorkflow.php
View file

@ -1,7 +0,0 @@
<?php
/**
* NOTE: Do not extend from this class, extend from @{class:ArcanistWorkflow}
* instead.
*/
abstract class ArcanistBaseWorkflow extends ArcanistWorkflow {}

9
src/workflow/ArcanistWorkflow.php
View file

@ -84,15 +84,6 @@ abstract class ArcanistWorkflow extends Phobject {
* whether the command succeeded or failed. * whether the command succeeded or failed.
*/ */
public function finalize() { public function finalize() {
// TODO: Remove this once ArcanistBaseWorkflow is gone.
if ($this instanceof ArcanistBaseWorkflow) {
phutil_deprecated(
'ArcanistBaseWorkflow',
pht(
'You should extend from `%s` instead.',
__CLASS__));
}
$this->finalizeWorkingCopy(); $this->finalizeWorkingCopy();
} }