mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-26 00:32:41 +01:00
Remove deprecated "base" classes
Summary: Ref T5655. After D9983, `ArcanistBaseWorkflow` and `ArcanistBaseUnitTestEngine` are deprecated. Test Plan: Wait a sufficient amount of time before landing this. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D10004
This commit is contained in:
parent
e1a051a033
commit
f9cefb7e2d
5 changed files with 0 additions and 34 deletions
|
@ -15,8 +15,6 @@ phutil_register_library_map(array(
|
|||
'ArcanistBackoutWorkflow' => 'workflow/ArcanistBackoutWorkflow.php',
|
||||
'ArcanistBaseCommitParser' => 'parser/ArcanistBaseCommitParser.php',
|
||||
'ArcanistBaseCommitParserTestCase' => 'parser/__tests__/ArcanistBaseCommitParserTestCase.php',
|
||||
'ArcanistBaseUnitTestEngine' => 'unit/engine/ArcanistBaseUnitTestEngine.php',
|
||||
'ArcanistBaseWorkflow' => 'workflow/ArcanistBaseWorkflow.php',
|
||||
'ArcanistBaseXHPASTLinter' => 'lint/linter/ArcanistBaseXHPASTLinter.php',
|
||||
'ArcanistBookmarkWorkflow' => 'workflow/ArcanistBookmarkWorkflow.php',
|
||||
'ArcanistBranchWorkflow' => 'workflow/ArcanistBranchWorkflow.php',
|
||||
|
@ -220,8 +218,6 @@ phutil_register_library_map(array(
|
|||
'ArcanistAnoidWorkflow' => 'ArcanistWorkflow',
|
||||
'ArcanistBackoutWorkflow' => 'ArcanistWorkflow',
|
||||
'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
|
||||
'ArcanistBaseUnitTestEngine' => 'ArcanistUnitTestEngine',
|
||||
'ArcanistBaseWorkflow' => 'ArcanistWorkflow',
|
||||
'ArcanistBaseXHPASTLinter' => 'ArcanistFutureLinter',
|
||||
'ArcanistBookmarkWorkflow' => 'ArcanistFeatureWorkflow',
|
||||
'ArcanistBranchWorkflow' => 'ArcanistFeatureWorkflow',
|
||||
|
|
|
@ -1,7 +0,0 @@
|
|||
<?php
|
||||
|
||||
/**
|
||||
* NOTE: Do not extend from this class, extend from
|
||||
* @{class:ArcanistUnitTestEngine} instead.
|
||||
*/
|
||||
abstract class ArcanistBaseUnitTestEngine extends ArcanistUnitTestEngine {}
|
|
@ -51,13 +51,6 @@ abstract class ArcanistUnitTestEngine {
|
|||
final public function setWorkingCopy(
|
||||
ArcanistWorkingCopyIdentity $working_copy) {
|
||||
|
||||
// TODO: Remove this once ArcanistBaseUnitTestEngine is gone.
|
||||
if ($this instanceof ArcanistBaseUnitTestEngine) {
|
||||
phutil_deprecated(
|
||||
'ArcanistBaseUnitTestEngine',
|
||||
pht('You should extend from `%s` instead.', __CLASS__));
|
||||
}
|
||||
|
||||
$this->workingCopy = $working_copy;
|
||||
return $this;
|
||||
}
|
||||
|
|
|
@ -1,7 +0,0 @@
|
|||
<?php
|
||||
|
||||
/**
|
||||
* NOTE: Do not extend from this class, extend from @{class:ArcanistWorkflow}
|
||||
* instead.
|
||||
*/
|
||||
abstract class ArcanistBaseWorkflow extends ArcanistWorkflow {}
|
|
@ -84,15 +84,6 @@ abstract class ArcanistWorkflow extends Phobject {
|
|||
* whether the command succeeded or failed.
|
||||
*/
|
||||
public function finalize() {
|
||||
// TODO: Remove this once ArcanistBaseWorkflow is gone.
|
||||
if ($this instanceof ArcanistBaseWorkflow) {
|
||||
phutil_deprecated(
|
||||
'ArcanistBaseWorkflow',
|
||||
pht(
|
||||
'You should extend from `%s` instead.',
|
||||
__CLASS__));
|
||||
}
|
||||
|
||||
$this->finalizeWorkingCopy();
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue