revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 00:42:40 +01:00
Code Issues Releases Wiki Activity

(stable) Fix an initialization issue in VectorTree

Browse source 
Summary: Ref T13520. In unusual cases where there are no changes in a changeset list (e.g., empty commits) we can fatal when trying to iterate over an empty list of vectors.

Test Plan:
  - Created an empty commit.
  - Used "git show | pbcopy" to create a diff from it.
  - Viewed it in the web UI.
  - Before: fatal when iterating on `null`.
  - After: clean page.

Maniphest Tasks: T13520

Differential Revision: https://secure.phabricator.com/D21221
This commit is contained in:
epriestley 2020-05-04 15:42:30 -07:00
parent 31c6b56b67
commit fb3e4014fc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/difference/ArcanistDiffVectorTree.php
View file

@ -3,7 +3,7 @@
final class ArcanistDiffVectorTree
extends Phobject {
private $vectors;
private $vectors = array();
public function addVector(array $vector) {
$this->vectors[] = $vector;