revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-10-23 17:18:50 +02:00
Code Issues Releases Wiki Activity

Add more information about Harbormaster/Unit result codes to Arcanist

Browse source 
Summary: Ref T7419. This makes it easier to render helpful documentation in the next diff without having to copy/paste things.

Test Plan:
In next diff:

{F688894}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7419

Differential Revision: https://secure.phabricator.com/D13788
This commit is contained in:
epriestley 2015-08-04 13:05:38 -07:00
parent 0d6f3328a0
commit fb5d5b86fa
1 changed files with 64 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
src/unit/ArcanistUnitTestResult.php
View file

@ -152,4 +152,68 @@ final class ArcanistUnitTestResult extends Phobject {
);
}
public static function getAllResultCodes() {
return array(
self::RESULT_PASS,
self::RESULT_FAIL,
self::RESULT_SKIP,
self::RESULT_BROKEN,
self::RESULT_UNSOUND,
);
}
public static function getResultCodeName($result_code) {
$spec = self::getResultCodeSpec($result_code);
if (!$spec) {
return null;
}
return idx($spec, 'name');
}
public static function getResultCodeDescription($result_code) {
$spec = self::getResultCodeSpec($result_code);
if (!$spec) {
return null;
}
return idx($spec, 'description');
}
private static function getResultCodeSpec($result_code) {
$specs = self::getResultCodeSpecs();
return idx($specs, $result_code);
}
private static function getResultCodeSpecs() {
return array(
self::RESULT_PASS => array(
'name' => pht('Pass'),
'description' => pht(
'The test passed.'),
),
self::RESULT_FAIL => array(
'name' => pht('Fail'),
'description' => pht(
'The test failed.'),
),
self::RESULT_SKIP => array(
'name' => pht('Skip'),
'description' => pht(
'The test was not executed.'),
),
self::RESULT_BROKEN => array(
'name' => pht('Broken'),
'description' => pht(
'The test failed in an abnormal or severe way. For example, the '.
'harness crashed instead of reporting a failure.'),
),
self::RESULT_UNSOUND => array(
'name' => pht('Unsound'),
'description' => pht(
'The test failed, but this change is probably not what broke it. '.
'For example, it might have already been failing.'),
),
);
}
}