revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Correctly identify @todo comments as TODOs.

Browse source 
Summary: Allow `@todo` comments to be linted as TODOs as well as `TODO` comments.

Test Plan: I added a new test case (`todo.lint-test`)

Reviewers: #blessed_reviewers, epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8389
This commit is contained in:
Joshua Spence 2014-03-04 11:03:09 -08:00 committed by epriestley
parent 0888b6616c
commit fb826bbf9c
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lint/linter/ArcanistXHPASTLinter.php
View file

@ -2036,9 +2036,15 @@ final class ArcanistXHPASTLinter extends ArcanistBaseXHPASTLinter {
foreach ($comments as $token) { foreach ($comments as $token) {
$value = $token->getValue(); $value = $token->getValue();
if ($token->getTypeName() === 'T_DOC_COMMENT') {
$regex = '/(TODO|@todo)/';
} else {
$regex = '/TODO/';
}
$matches = null; $matches = null;
$preg = preg_match_all( $preg = preg_match_all(
'/TODO/', $regex,
$value, $value,
$matches, $matches,
PREG_OFFSET_CAPTURE); PREG_OFFSET_CAPTURE);

10
src/lint/linter/__tests__/xhpast/todo.lint-test Normal file
View file

@ -0,0 +1,10 @@
<?php
// TODO: Something goes here.
/**
* @todo Something else goes here.
*/
~~~~~~~~~~
disabled:3:4
disabled:6:4