From fba87a5b6a3e1b497e09a6e86460da4547076dc9 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 9 Mar 2012 08:57:03 -0800 Subject: [PATCH] Fix implicit fallthrough in arc Summary: Raised by new linter. Test Plan: Lint/inspection. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1831 --- src/lint/linter/xhpast/ArcanistXHPASTLinter.php | 1 + src/parser/diff/ArcanistDiffParser.php | 1 + 2 files changed, 2 insertions(+) diff --git a/src/lint/linter/xhpast/ArcanistXHPASTLinter.php b/src/lint/linter/xhpast/ArcanistXHPASTLinter.php index c24db6e5..dd5861bf 100644 --- a/src/lint/linter/xhpast/ArcanistXHPASTLinter.php +++ b/src/lint/linter/xhpast/ArcanistXHPASTLinter.php @@ -1460,6 +1460,7 @@ final class ArcanistXHPASTLinter extends ArcanistLinter { default: $key = null; + break; } if ($key !== null) { diff --git a/src/parser/diff/ArcanistDiffParser.php b/src/parser/diff/ArcanistDiffParser.php index 061a49a6..231f6576 100644 --- a/src/parser/diff/ArcanistDiffParser.php +++ b/src/parser/diff/ArcanistDiffParser.php @@ -305,6 +305,7 @@ final class ArcanistDiffParser { break; default: $this->didFailParse("Unknown diff type."); + break; } } while ($this->getLine() !== null);