Use PhutilLibraryTestCase

Summary: Depends on D11231.

Test Plan: `arc unit`

Reviewers: btrahan, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11232

src/__phutil_library_map__.php

@@ -94,7 +94,6 @@ phutil_register_library_map(array(
     'ArcanistHgProxyServer' => 'hgdaemon/ArcanistHgProxyServer.php',
     'ArcanistHgServerChannel' => 'hgdaemon/ArcanistHgServerChannel.php',
     'ArcanistHookAPI' => 'repository/hookapi/ArcanistHookAPI.php',
-    'ArcanistInfrastructureTestCase' => '__tests__/ArcanistInfrastructureTestCase.php',
     'ArcanistInstallCertificateWorkflow' => 'workflow/ArcanistInstallCertificateWorkflow.php',
     'ArcanistJSHintLinter' => 'lint/linter/ArcanistJSHintLinter.php',
     'ArcanistJSHintLinterTestCase' => 'lint/linter/__tests__/ArcanistJSHintLinterTestCase.php',
@@ -109,6 +108,7 @@ phutil_register_library_map(array(
     'ArcanistLesscLinter' => 'lint/linter/ArcanistLesscLinter.php',
     'ArcanistLesscLinterTestCase' => 'lint/linter/__tests__/ArcanistLesscLinterTestCase.php',
     'ArcanistLiberateWorkflow' => 'workflow/ArcanistLiberateWorkflow.php',
+    'ArcanistLibraryTestCase' => '__tests__/ArcanistLibraryTestCase.php',
     'ArcanistLintEngine' => 'lint/engine/ArcanistLintEngine.php',
     'ArcanistLintMessage' => 'lint/ArcanistLintMessage.php',
     'ArcanistLintPatcher' => 'lint/ArcanistLintPatcher.php',
@@ -286,7 +286,6 @@ phutil_register_library_map(array(
     'ArcanistHelpWorkflow' => 'ArcanistWorkflow',
     'ArcanistHgClientChannel' => 'PhutilProtocolChannel',
     'ArcanistHgServerChannel' => 'PhutilProtocolChannel',
-    'ArcanistInfrastructureTestCase' => 'ArcanistTestCase',
     'ArcanistInstallCertificateWorkflow' => 'ArcanistWorkflow',
     'ArcanistJSHintLinter' => 'ArcanistExternalLinter',
     'ArcanistJSHintLinterTestCase' => 'ArcanistExternalLinterTestCase',
@@ -301,6 +300,7 @@ phutil_register_library_map(array(
     'ArcanistLesscLinter' => 'ArcanistExternalLinter',
     'ArcanistLesscLinterTestCase' => 'ArcanistExternalLinterTestCase',
     'ArcanistLiberateWorkflow' => 'ArcanistWorkflow',
+    'ArcanistLibraryTestCase' => 'PhutilLibraryTestCase',
     'ArcanistLintWorkflow' => 'ArcanistWorkflow',
     'ArcanistLinterTestCase' => 'ArcanistPhutilTestCase',
     'ArcanistLintersWorkflow' => 'ArcanistWorkflow',

src/__tests__/ArcanistInfrastructureTestCase.php

@@ -1,37 +0,0 @@
-<?php
-
-final class ArcanistInfrastructureTestCase extends ArcanistTestCase {
-
-  /**
-   * This is more of an acceptance test case instead of a unit test. It verifies
-   * that all symbols can be loaded correctly. It can catch problems like
-   * missing methods in descendants of abstract base classes.
-   */
-  public function testEverythingImplemented() {
-    id(new PhutilSymbolLoader())->selectAndLoadSymbols();
-    $this->assertTrue(true);
-  }
-
-  /**
-   * This is more of an acceptance test case instead of a unit test. It verifies
-   * that all the library map is up-to-date.
-   */
-  public function testLibraryMap() {
-    $library = phutil_get_current_library_name();
-    $root = phutil_get_library_root($library);
-
-    $new_library_map = id(new PhutilLibraryMapBuilder($root))
-      ->buildMap();
-
-    $bootloader = PhutilBootloader::getInstance();
-    $old_library_map = $bootloader->getLibraryMapWithoutExtensions($library);
-    unset($old_library_map[PhutilLibraryMapBuilder::LIBRARY_MAP_VERSION_KEY]);
-
-    $this->assertEqual(
-      $new_library_map,
-      $old_library_map,
-      'The library map does not appear to be up-to-date. Try '.
-      'rebuilding the map with `arc liberate`.');
-  }
-
-}

src/__tests__/ArcanistLibraryTestCase.php

@@ -0,0 +1,3 @@
+<?php
+
+final class ArcanistLibraryTestCase extends PhutilLibraryTestCase {}