revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-28 09:42:40 +01:00
Code Issues Releases Wiki Activity

Return STDIN, STDOUT, and STDERR file descriptors from parent process

Browse source 
Summary:
Ref T13675. When a process daemonizes, it needs to close these actual file descriptors, so the calling context must provide them.

Elsewhere, modify the embedded "arc" to provide them. Then use them in place of reopening the streams.

Test Plan: Ran locally with embedded "arc", will deploy for production hangs.

Maniphest Tasks: T13675

Differential Revision: https://secure.phabricator.com/D21804
This commit is contained in:
epriestley 2022-05-05 09:52:46 -07:00
parent 2969f24961
commit fc5b228db5
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/utils/PhutilSystem.php
View file

@ -17,7 +17,7 @@ final class PhutilSystem extends Phobject {
*/
public static function getStdinHandle() {
if (self::$stdin === false) {
self::$stdin = self::newStdioHandle('php://stdin');
self::$stdin = self::getStdioHandle('STDIN');
}
return self::$stdin;
@ -28,7 +28,7 @@ final class PhutilSystem extends Phobject {
*/
public static function getStdoutHandle() {
if (self::$stdout === false) {
self::$stdout = self::newStdioHandle('php://stdout');
self::$stdout = self::getStdioHandle('STDOUT');
}
return self::$stdout;
@ -39,7 +39,7 @@ final class PhutilSystem extends Phobject {
*/
public static function getStderrHandle() {
if (self::$stderr === false) {
self::$stderr = self::newStdioHandle('php://stderr');
self::$stderr = self::getStdioHandle('STDERR');
}
return self::$stderr;
@ -63,15 +63,12 @@ final class PhutilSystem extends Phobject {
/**
* @task stdio
*/
private static function newStdioHandle($ref) {
$ignored_mode = '';
$handle = @fopen($ref, $ignored_mode);
if ($handle === false) {
return null;
private static function getStdioHandle($ref) {
if (defined($ref)) {
return constant($ref);
}
return $handle;
return null;
}
/**