revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 02:02:40 +01:00
Code Issues Releases Wiki Activity

Allow setCustomSeverityRules to be overridden in subclasses

Browse source 
Summary:
I am writing a proxy linter that can be used to wrap any `ArcanistExternalLinter` and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |`ArcanistDockerContainerLinterProxy`]] from [[https://github.com/freelancer/flarc | `flarc`]]). In order for `ArcanistDockerContainerLinterProxy` to behave like the `ArcanistExternalLinter` that is being proxied, `final` needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change ({D19630}) was previously accepted.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20514
This commit is contained in:
Joshua Spence 2019-05-15 09:03:02 +10:00
parent 4f583dded3
commit fceac878f1
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/lint/linter/ArcanistLinter.php
View file

@ -214,9 +214,6 @@ abstract class ArcanistLinter extends Phobject {
return 1.0; return 1.0;
} }
/**
* TODO: This should be `final`.
*/
public function setCustomSeverityMap(array $map) { public function setCustomSeverityMap(array $map) {
$this->customSeverityMap = $map; $this->customSeverityMap = $map;
return $this; return $this;
@ -227,7 +224,7 @@ abstract class ArcanistLinter extends Phobject {
return $this; return $this;
} }
final public function setCustomSeverityRules(array $rules) { public function setCustomSeverityRules(array $rules) {
$this->customSeverityRules = $rules; $this->customSeverityRules = $rules;
return $this; return $this;
} }