revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-08 16:02:39 +01:00
Code Issues Releases Wiki Activity
262 commits 5 branches 7 tags 12 MiB
Commit graph

262 commits

This branch
This branch
All branches
Author SHA1 Message Date
epriestley
4b1c4238bc Fix two common points of confusion: 
- show "push upstream" instructions after arc amend
	- parse 'diffcamp revision'

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 18:47:17 -08:00
epriestley
ba6091f945 Add @nocommit and tests to Text linter. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 17:26:51 -08:00
epriestley
2354d544e3 Restore hook configuration in lint unit tests. Make working copy setup an 
external.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 11:53:34 -08:00
epriestley
2f37912946 Expose the already-functional "--engine" flag for the unit workflow. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 11:53:13 -08:00
epriestley
834b375e47 Improve bash completion for commands like 'arc lint' and 'arc unit'. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 11:51:06 -08:00
epriestley
1040046f3a Support --load-phutil-library in arcanist. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 10:07:48 -08:00
epriestley
7ef47d3e15 More SVN hook docs. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-16 10:06:44 -08:00
epriestley
026269a707 Inch toward a defensibly documented project state. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-15 15:10:53 -08:00
epriestley
ca98fc175f Add lint support to 'arc svn-hook-pre-commit'. 
Summary: The biggest blocker on getting rid of arc in trunk is that the lint
rules in the commit hooks are still running the old version. Push arc
commit hook support toward some reasonable state of approximately working.

Test Plan:

Reviewers:

CC:
 2011-02-15 14:57:24 -08:00
epriestley
d2b5d9108b Provide coverage for the xhpast $a->b->c parsing bug exposed by tautolinting the 
codebase.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-13 16:43:32 -08:00
epriestley
b3b2da4608 Fix greediness in Apache License linter. 
Summary: The multi-line comment regexp was potentially too greedy. See
"greedy.lint-test".
	- Made it less greedy.
	- Added test coverage.
	- Fixed an issue with the Apache license getting applied with too much
	  whitespace against C files.

Test Plan: Ran unit tests.

Reviewers: aran

CC:

Differential Revision: 36
 2011-02-13 16:03:05 -08:00
adonohue
e0bc910dda Tweak license linter to support licenses on line immediately after <?php 
Summary:
Tweak license linter to support licenses on line immediately after <?php

Test Plan:
Corrupt an apache license and re-lint twice.

Differential Revision: 34
Reviewed By: epriestley
Reviewers: epriestley
 2011-02-11 17:51:55 -08:00
adonohue
f22d74f88d Refactor Apache license linter to parameterize the license itself. 
Summary:
Refactor Apache license linter to parameterize the license itself.

Test Plan:
meta

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

Differential Revision: 33
Reviewed By: epriestley
Reviewers: epriestley
 2011-02-11 16:36:09 -08:00
epriestley
f20db032bd Align Arcanist against phabricator.com. 
Summary:
dogfood etc

Test Plan:
meta

Differential Revision: 28
Reviewed By: tomo
Reviewers: aran, tomo
 2011-02-09 20:45:39 -08:00
epriestley
2119a81b99 Basic doc config for arcanist. 2011-02-09 17:06:24 -08:00
epriestley
16db51bc3c Don't try to mark committed when running "arc amend --show". 2011-02-09 09:39:17 -08:00
epriestley
f938293ea8 Make Arcanist understand a phid-based response from 
differential.parsecommitmessage.
 2011-02-09 09:19:22 -08:00
epriestley
6082b89eb4 Use the '(?P<' syntax instead of '(?<' for capturing named subgroups. 2011-02-09 09:12:21 -08:00
epriestley
4b51720ba1 Tautological expression lint. 2011-02-06 13:04:01 -08:00
epriestley
db9f629499 Stop arc from triggering bogus exceptions. 2011-02-05 23:32:04 -08:00
epriestley
c44c4cf988 Hook up conduit auth. 2011-02-05 22:44:30 -08:00
epriestley
c97b736a21 Treat empty update message as user abort on 'arc diff' workflow 
Summary:
"-m ''" will still let you do a truly empty update if
you are insistent on that.

Test Plan:
meta

Differential Revision: 209194
Reviewed By: dschleimer
Reviewers: dschleimer
CC: epriestley
Revert Plan:
OK
 2011-02-04 16:08:53 -08:00
epriestley
89a3606406 Merge branch 'master' of github.com:facebook/arcanist 2011-02-03 16:00:05 -08:00
epriestley
d7219a1619 Add a missing 'static' qualifier. 2011-02-03 15:59:45 -08:00
epriestley
83a0083b3b Improve argument passthru behavior to make added args available to test engines. 
Summary:
When you add new arguments to the unit command, they need to be
threaded through to the unit engine. This enables you to specify passthru
command which will be shipped through the callstack.

Test Plan:
Ran 'arc diff --maxtests 8 --apply-patches --trace' and verified
resulting behavior was correct.

Differential Revision: 207877
Reviewed By: dschleimer
Reviewers: dschleimer
CC: dschleimer
Revert Plan:
OK
 2011-02-01 20:45:32 -08:00
epriestley
9a699f261a Make change amending explicit in arc lint 
Summary:
This should only happen on the 'diff' workflow.

Test Plan:
ran 'arc lint' and didn't get prompted to amend, ran 'arc diff' and got yelled
at for uncommitted changes, committed, ran 'arc diff' and got prompted to amend

Differential Revision: 206696
Reviewed By: adonohue
Reviewers: adonohue
CC: adonohue
Revert Plan:
OK
 2011-01-29 17:28:57 -08:00
epriestley
100c55cf45 Make "arc export" work from a local git repo 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-29 12:45:37 -08:00
epriestley
9affcb0db2 Expose XHPAST parse tree down the line to other parsers. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-28 15:18:19 -08:00
epriestley
042081b47f Merge branch 'master' of github.com:facebook/arcanist 2011-01-28 11:38:45 -08:00
epriestley
ac7fd22061 Fix a bogus idx() call. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-28 11:37:44 -08:00
epriestley
072833dcb4 Merge branch 'master' of github.com:facebook/arcanist 2011-01-26 17:47:00 -08:00
epriestley
777c69699b Don't apply apache license lint rules if there is no copyright holder. 2011-01-26 17:46:17 -08:00
adonohue
c896d3814f [easy] remove no-op from ArcanistLinter#raiseLintAtPath 
Summary:
Remove extra call to getActivePath

Test Plan:
Inspection

Differential Revision: 205579
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley
Revert Plan:
OK
 2011-01-26 17:33:35 -08:00
epriestley
d933f20005 Blanket exclude 'externals/' directory from linting in the PhutilLintEngine. 2011-01-26 09:58:16 -08:00
epriestley
d46a138eb0 Don't issue lint about strangely named classes just because they have some 
word character in them.
 2011-01-26 07:03:52 -08:00
epriestley
71ff2d85de Use caching to provide a huge perf boost to phutil_mapper. 2011-01-25 18:05:15 -08:00
epriestley
210b4fe07d Include CSS and JS in PhutilLintEngine. 2011-01-25 11:32:57 -08:00
epriestley
7f4e6692cd Add ArcanistDiffUtils. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-24 16:48:20 -08:00
epriestley
adef7d4975 Expose diff IDs to post-diff workflows. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-21 16:17:30 -08:00
epriestley
746768e779 Enable PhutilModuleLinter to recover more gracefully from broken modules. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-17 20:18:42 -08:00
epriestley
4818892841 Basic 'shell-complete' workflow. 
Summary:
Adds data-driven shell completion help to arcanist.

Test Plan:
ran various commands in git and svn working copies,
output seemed reasonable

Differential Revision: 201754
Reviewed By: adonohue
Reviewers: mroch, adonohue
Commenters: crackerjack
CC: epriestley, adonohue, achao
Revert Plan:
OK
 2011-01-17 20:18:27 -08:00
adonohue
026a322dd2 Implement lint check that filename matches only declared interface/class. 
Differential Revision: 201593
Reviewed By: epriestley
 2011-01-14 15:30:11 -08:00
adonohue
59f48f7901 Disable phutil filename check. To be implemented as a more pervasive check. 
Differential Revision: 201587
Reviewed By: epriestley
 2011-01-14 15:21:39 -08:00
epriestley
68dee48bf4 Clarify confusing error message about missing .arcconfig vs missing conduit. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-13 15:36:15 -08:00
epriestley
2c4b453757 Correct some references to '--diff-only', now '--preview'. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-13 15:31:37 -08:00
epriestley
50f42aad8d Provide a better error message for 'arc patch' when patches fail. 
Summary:
Be more clear about what happened.

Test Plan:
ran 'arc patch' on good/bad patches

Differential Revision: 201085
Reviewed By: adonohue
Reviewers: adonohue
CC: adonohue
Revert Plan:
OK
 2011-01-13 13:40:09 -08:00
epriestley
8c73ed915d Fix a typo ish. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-12 17:20:45 -08:00
epriestley
3f13e36182 Update arcanist to use the PhutilSymbolLoader. 
Summary: This should also fix the bug with double help for certain commands

Test Plan:

Reviewers:

CC:
 2011-01-12 16:02:28 -08:00
epriestley
c8b303bc90 Add SVN pre-commit hook support. 
Summary: Basic support for an SVN pre-commit hook. Still very skeletal.

Test Plan:

Reviewers:

CC:
 2011-01-12 03:02:05 -08:00
epriestley
7d36705215 Ship unresolved unit test information to Differential. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-01-11 22:37:06 -08:00