3 commits

Author	SHA1	Message	Date
epriestley	1f3cb63db2	Expose PEP8, Flake8 and CSSLint engines to .arclint ... Summary: Ref T3186. Ref T2039. Allow these linters to be selected with `.arclint`. Also allow severities to be set. Also fix some other minor bugs. Test Plan: https://github.com/epriestley/arclint-examples https://github.com/epriestley/arclint-examples/blob/master/.arclint Reviewers: btrahan Reviewed By: btrahan CC: chad, aran Maniphest Tasks: T2039, T3186 Differential Revision: https://secure.phabricator.com/D6803	2013-08-23 11:58:07 -07:00
epriestley	6e5be59ad6	Port flake8 to ArcanistExternalLinter ... Summary: Ref T3186. Brings another linter onboard. This one uses the stdin stuff. The unit test was ostensibly broken so I fixed it, but that might just be some kind of version issue. Test Plan: Unit tests. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3186 Differential Revision: https://secure.phabricator.com/D6802	2013-08-23 11:52:54 -07:00
epriestley	e23fc30c19	Introduce a rough abstract base class for "linters which run programs and read the results" ... Summary: Ref T3186. We have about 50 linters which run programs and read the results, all of which have ad-hoc one-off custom config that isn't formalized anywhere. Consolidate all this stuff into `ArcanistExternalLinter`, which is configurable through `.arclint` (although nothing supports this quite yet). Extend CSSLint and Pep8Lint from `ArcanistExternalLinter`. Add unit tests for both. There are still some rough edges here, but it mostly seems to work pretty well. Test Plan: Ran unit tests, hit some (most?) of the error cases. Reviewers: btrahan Reviewed By: btrahan CC: chad, aran, Firehed Maniphest Tasks: T3186 Differential Revision: https://secure.phabricator.com/D6800	2013-08-23 11:52:44 -07:00