8 commits

Author	SHA1	Message	Date
epriestley	4b30319747	Make XHPAST parse-depth warning an actual warning. ... Summary: XHPAST encounters a parse-depth problem on some files because PHP 5.2 has an un-overridable parse depth limit for JSON. The text of this error says it is a "warning" but we currently raise an error. Make it a warning instead. The JSON depth is 20 until PHP 5.2.3, where it becomes 128. After PHP 5.3 it defaults to 512 and is user-configurable, which will allow us to resolve this issue in nearly all cases. Since I made if/else express as a list in the AST, this only actually arises in long binary chains, most commonly string concatenation, like: $out = 'a'.'a'.'a'.'a'... ...where each string is a variable or HTML tag and the program is constructing a complicated document. At some point I'll add some PHP 5.3 massaging to the XHPAST decoder itself to raise this limit to something more huge. Test Plan: Ran "arc lint --lintall" on a file with a very deep binary expression tree ("1 + 1 + 1 ...") and received a warning instead of an error. Reviewed By: aran Reviewers: pad, aran CC: epriestley, aran Differential Revision: 54	2011-03-07 11:44:11 -08:00
epriestley	5099b005cf	Some documentation. ... Summary: Test Plan: Reviewers: CC:	2011-02-19 11:36:08 -08:00
epriestley	d2b5d9108b	Provide coverage for the xhpast $a->b->c parsing bug exposed by tautolinting the ... codebase. Summary: Test Plan: Reviewers: CC:	2011-02-13 16:43:32 -08:00
epriestley	4b51720ba1	Tautological expression lint.	2011-02-06 13:04:01 -08:00
epriestley	9affcb0db2	Expose XHPAST parse tree down the line to other parsers. ... Summary: Test Plan: Reviewers: CC:	2011-01-28 15:18:19 -08:00
epriestley	d46a138eb0	Don't issue lint about strangely named classes just because they have some ... word character in them.	2011-01-26 07:03:52 -08:00
adonohue	026a322dd2	Implement lint check that filename matches only declared interface/class. ... Differential Revision: 201593 Reviewed By: epriestley	2011-01-14 15:30:11 -08:00
epriestley	2e73916fa2	Initial commit.	2011-01-09 15:22:25 -08:00