epriestley
ca98fc175f
Add lint support to 'arc svn-hook-pre-commit'.
...
Summary: The biggest blocker on getting rid of arc in trunk is that the lint
rules in the commit hooks are still running the old version. Push arc
commit hook support toward some reasonable state of approximately working.
Test Plan:
Reviewers:
CC:
2011-02-15 14:57:24 -08:00
epriestley
d2b5d9108b
Provide coverage for the xhpast $a->b->c parsing bug exposed by tautolinting the
...
codebase.
Summary:
Test Plan:
Reviewers:
CC:
2011-02-13 16:43:32 -08:00
epriestley
b3b2da4608
Fix greediness in Apache License linter.
...
Summary: The multi-line comment regexp was potentially too greedy. See
"greedy.lint-test".
- Made it less greedy.
- Added test coverage.
- Fixed an issue with the Apache license getting applied with too much
whitespace against C files.
Test Plan: Ran unit tests.
Reviewers: aran
CC:
Differential Revision: 36
2011-02-13 16:03:05 -08:00
adonohue
e0bc910dda
Tweak license linter to support licenses on line immediately after <?php
...
Summary:
Tweak license linter to support licenses on line immediately after <?php
Test Plan:
Corrupt an apache license and re-lint twice.
Differential Revision: 34
Reviewed By: epriestley
Reviewers: epriestley
2011-02-11 17:51:55 -08:00
adonohue
f22d74f88d
Refactor Apache license linter to parameterize the license itself.
...
Summary:
Refactor Apache license linter to parameterize the license itself.
Test Plan:
meta
- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -
Differential Revision: 33
Reviewed By: epriestley
Reviewers: epriestley
2011-02-11 16:36:09 -08:00
epriestley
4b51720ba1
Tautological expression lint.
2011-02-06 13:04:01 -08:00
epriestley
9affcb0db2
Expose XHPAST parse tree down the line to other parsers.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-28 15:18:19 -08:00
epriestley
072833dcb4
Merge branch 'master' of github.com:facebook/arcanist
2011-01-26 17:47:00 -08:00
epriestley
777c69699b
Don't apply apache license lint rules if there is no copyright holder.
2011-01-26 17:46:17 -08:00
adonohue
c896d3814f
[easy] remove no-op from ArcanistLinter#raiseLintAtPath
...
Summary:
Remove extra call to getActivePath
Test Plan:
Inspection
Differential Revision: 205579
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley
Revert Plan:
OK
2011-01-26 17:33:35 -08:00
epriestley
d933f20005
Blanket exclude 'externals/' directory from linting in the PhutilLintEngine.
2011-01-26 09:58:16 -08:00
epriestley
d46a138eb0
Don't issue lint about strangely named classes just because they have some
...
word character in them.
2011-01-26 07:03:52 -08:00
epriestley
210b4fe07d
Include CSS and JS in PhutilLintEngine.
2011-01-25 11:32:57 -08:00
epriestley
746768e779
Enable PhutilModuleLinter to recover more gracefully from broken modules.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-17 20:18:42 -08:00
adonohue
026a322dd2
Implement lint check that filename matches only declared interface/class.
...
Differential Revision: 201593
Reviewed By: epriestley
2011-01-14 15:30:11 -08:00
adonohue
59f48f7901
Disable phutil filename check. To be implemented as a more pervasive check.
...
Differential Revision: 201587
Reviewed By: epriestley
2011-01-14 15:21:39 -08:00
epriestley
3f13e36182
Update arcanist to use the PhutilSymbolLoader.
...
Summary: This should also fix the bug with double help for certain commands
Test Plan:
Reviewers:
CC:
2011-01-12 16:02:28 -08:00
epriestley
bb7e649fa5
Ship lint warnings to Differential.
...
Summary: Send skipped lint warnings to Differential. This also fixes a nasty
bug with lint excluding too many warnings based on line changes.
Test Plan: meta
Reviewers:
CC:
Differential Revision: 200387
2011-01-11 20:45:36 -08:00
epriestley
10b0a553b4
Improve phutil module linter behavior for vanished modules and missing or
...
broken __init__.php.
Summary: This allows phutilmodulelinter to generate missing __init__.php and
recover from missing modules without horrible fataltown.
Test Plan:
Reviewers:
CC:
2011-01-10 00:07:58 -08:00
epriestley
12f1ba1d77
Remove XHPAST from arcanist.
...
Summary: see corresponding commit in libphutil
Test Plan: linted and analyzed both libraries, got more sensible build behavior
Reviewers:
CC:
2011-01-09 22:13:30 -08:00
epriestley
efb8219196
Fix some problems with the module linter that would cause various conflicting
...
warnings raised in __init__.php to overwrite eachother in uncomfortable ways.
2011-01-09 20:40:31 -08:00
epriestley
2c235bdf38
Fix a couple of lint issues, and update to version 2 (github).
2011-01-09 15:51:04 -08:00
epriestley
2e73916fa2
Initial commit.
2011-01-09 15:22:25 -08:00
