phorge-arcanist

1460 commits 5 branches 7 tags 12 MiB

Author	SHA1	Message	Date
epriestley	4c476c0201	Make Arcanist workflow names explicit Summary: Currently, adding a new workflow requires you to override ArcanistConfiguration, which is messy. Instead, just load everything that extends ArcanistBaseWorkflow. Remove all the rules tying workflow names to class names through arcane incantations. This has a very small performance cost in that we need to load every Workflow class every time now, but we don't hit __init__ and such anymore and it was pretty negligible on my machine (98ms vs 104ms or something). Test Plan: Ran "arc help", "arc which", "arc diff", etc. Reviewers: edward, vrana, btrahan Reviewed By: edward CC: aran, zeeg Differential Revision: https://secure.phabricator.com/D3691	2012-10-17 08:35:03 -07:00
epriestley	1d5a2aff20	Allow the "arc land --onto" default to be read from user config Summary: Allow the default to be set in global config, not just project config. Test Plan: `arc set-config arc.land.onto.default derp; arc land` Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2686	2012-06-20 12:29:07 -07:00
vrana	0b45ec30be	Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637	2012-06-01 11:56:00 -07:00

Author

SHA1

Message

Date

epriestley

4c476c0201

Make Arcanist workflow names explicit

Summary:
Currently, adding a new workflow requires you to override ArcanistConfiguration, which is messy. Instead, just load everything that extends ArcanistBaseWorkflow.

Remove all the rules tying workflow names to class names through arcane incantations.

This has a very small performance cost in that we need to load every Workflow class every time now, but we don't hit __init__ and such anymore and it was pretty negligible on my machine (98ms vs 104ms or something).

Test Plan: Ran "arc help", "arc which", "arc diff", etc.

Reviewers: edward, vrana, btrahan

Reviewed By: edward

CC: aran, zeeg

Differential Revision: https://secure.phabricator.com/D3691

2012-10-17 08:35:03 -07:00

epriestley

1d5a2aff20

Allow the "arc land --onto" default to be read from user config

Summary: Allow the default to be set in global config, not just project config.

Test Plan: `arc set-config arc.land.onto.default derp; arc land`

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D2686

2012-06-20 12:29:07 -07:00

vrana

0b45ec30be

Move files in Arcanist one level up

Summary:
- `kill_init.php`
- Manually change library map.
- Manually rename `/data/` test dirs.
- [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/`
- `arc liberate`

Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T1103

Differential Revision: https://secure.phabricator.com/D2637

2012-06-01 11:56:00 -07:00

Renamed from src/workflow/land/ArcanistLandWorkflow.php (Browse further)

53 commits