phorge-arcanist

revi-archive/phorge-arcanist

Fork 0

mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00

Commit graph

Author	SHA1	Message	Date
epriestley	7ae1a0ec40	Minor, address feedback from @vrana on D2585 . Auditors: vrana	2012-05-30 07:33:46 -07:00
epriestley	4eb6b97097	Export extends/implements information in the new libphutil library map Summary: For `PhutilSymbolLoader` queries which include `setAncestorClass()`, we need the map of which classes/interfaces things extend/implement to issue the query efficiently. Without this map, we need to load //every// class/interface and then do `is_subclass_of()`. This is doable, but not very performant if we don't have php-fpm warmup. There are a few performance-sensitive interfaces where we run queries like this, including some in Arcanist, where we'll never have warmup. This map isn't particularly difficult to generate or maintain, so just include it in symbol generation and in the library map. Also set parallelism with a flag, since it was arbitrarily hard-coded and adding flags is easy. 8 actually seems approximately optimal on my machine at least, though. Test Plan: Ran "phutil_rebuild_map.php", opened library map, got a reasonable extension map. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2585	2012-05-29 11:17:34 -07:00
epriestley	81976ff2ff	Provide a simpler analyzer script for killing __init__.php Summary: The `phutil_analyzer.php` script currently analyzes entire modules and is fairly complex. We don't need or want this in a post-__init__.php world. This is basically a simplified version of `phutil_analyzer.php`, which takes one file and emits symbols. Test Plan: ```$ ./scripts/phutil_symbols.php resources/test/diverse_symbols.php { "have" : { "function" : { "f" : 348 }, "class" : { "L" : 308, "A" : 497, "C" : 509, "D" : 531, "CLocal" : 627 }, "interface" : { "ILocal" : 593 } }, "need" : { "function" : { "g" : 402, "h" : 462 }, "class" : { "B" : 519, "INonlocal" : 642, "U" : 552, "X" : 421, "V" : 557, "W" : 565, "P" : 572 }, "interface" : { "IForeign" : 608 } } }``` Reviewers: vrana, nh, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2561	2012-05-24 10:56:56 -07:00

Author

SHA1

Message

Date

epriestley

7ae1a0ec40

Minor, address feedback from @vrana on D2585 .

Auditors: vrana

2012-05-30 07:33:46 -07:00

epriestley

4eb6b97097

Export extends/implements information in the new libphutil library map

Summary:
For `PhutilSymbolLoader` queries which include `setAncestorClass()`, we need the map of which classes/interfaces things extend/implement to issue the query efficiently.

Without this map, we need to load //every// class/interface and then do `is_subclass_of()`. This is doable, but not very performant if we don't have php-fpm warmup. There are a few performance-sensitive interfaces where we run queries like this, including some in Arcanist, where we'll never have warmup.

This map isn't particularly difficult to generate or maintain, so just include it in symbol generation and in the library map.

Also set parallelism with a flag, since it was arbitrarily hard-coded and adding flags is easy. 8 actually seems approximately optimal on my machine at least, though.

Test Plan: Ran "phutil_rebuild_map.php", opened library map, got a reasonable extension map.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1103

Differential Revision: https://secure.phabricator.com/D2585

2012-05-29 11:17:34 -07:00

epriestley

81976ff2ff

Provide a simpler analyzer script for killing __init__.php

Summary:
The `phutil_analyzer.php` script currently analyzes entire modules and is fairly complex. We don't need or want this in a post-__init__.php world.

This is basically a simplified version of `phutil_analyzer.php`, which takes one file and emits symbols.

Test Plan:
```$ ./scripts/phutil_symbols.php resources/test/diverse_symbols.php
{
  "have" : {
    "function"  : {
      "f" : 348
    },
    "class"     : {
      "L"      : 308,
      "A"      : 497,
      "C"      : 509,
      "D"      : 531,
      "CLocal" : 627
    },
    "interface" : {
      "ILocal" : 593
    }
  },
  "need" : {
    "function"  : {
      "g" : 402,
      "h" : 462
    },
    "class"     : {
      "B"         : 519,
      "INonlocal" : 642,
      "U"         : 552,
      "X"         : 421,
      "V"         : 557,
      "W"         : 565,
      "P"         : 572
    },
    "interface" : {
      "IForeign" : 608
    }
  }
}```

Reviewers: vrana, nh, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1103

Differential Revision: https://secure.phabricator.com/D2561

2012-05-24 10:56:56 -07:00

3 commits