epriestley
ac7fd22061
Fix a bogus idx() call.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-28 11:37:44 -08:00
epriestley
072833dcb4
Merge branch 'master' of github.com:facebook/arcanist
2011-01-26 17:47:00 -08:00
epriestley
777c69699b
Don't apply apache license lint rules if there is no copyright holder.
2011-01-26 17:46:17 -08:00
adonohue
c896d3814f
[easy] remove no-op from ArcanistLinter#raiseLintAtPath
...
Summary:
Remove extra call to getActivePath
Test Plan:
Inspection
Differential Revision: 205579
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley
Revert Plan:
OK
2011-01-26 17:33:35 -08:00
epriestley
d933f20005
Blanket exclude 'externals/' directory from linting in the PhutilLintEngine.
2011-01-26 09:58:16 -08:00
epriestley
d46a138eb0
Don't issue lint about strangely named classes just because they have some
...
word character in them.
2011-01-26 07:03:52 -08:00
epriestley
71ff2d85de
Use caching to provide a huge perf boost to phutil_mapper.
2011-01-25 18:05:15 -08:00
epriestley
210b4fe07d
Include CSS and JS in PhutilLintEngine.
2011-01-25 11:32:57 -08:00
epriestley
7f4e6692cd
Add ArcanistDiffUtils.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-24 16:48:20 -08:00
epriestley
adef7d4975
Expose diff IDs to post-diff workflows.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-21 16:17:30 -08:00
epriestley
746768e779
Enable PhutilModuleLinter to recover more gracefully from broken modules.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-17 20:18:42 -08:00
epriestley
4818892841
Basic 'shell-complete' workflow.
...
Summary:
Adds data-driven shell completion help to arcanist.
Test Plan:
ran various commands in git and svn working copies,
output seemed reasonable
Differential Revision: 201754
Reviewed By: adonohue
Reviewers: mroch, adonohue
Commenters: crackerjack
CC: epriestley, adonohue, achao
Revert Plan:
OK
2011-01-17 20:18:27 -08:00
adonohue
026a322dd2
Implement lint check that filename matches only declared interface/class.
...
Differential Revision: 201593
Reviewed By: epriestley
2011-01-14 15:30:11 -08:00
adonohue
59f48f7901
Disable phutil filename check. To be implemented as a more pervasive check.
...
Differential Revision: 201587
Reviewed By: epriestley
2011-01-14 15:21:39 -08:00
epriestley
68dee48bf4
Clarify confusing error message about missing .arcconfig vs missing conduit.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-13 15:36:15 -08:00
epriestley
2c4b453757
Correct some references to '--diff-only', now '--preview'.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-13 15:31:37 -08:00
epriestley
50f42aad8d
Provide a better error message for 'arc patch' when patches fail.
...
Summary:
Be more clear about what happened.
Test Plan:
ran 'arc patch' on good/bad patches
Differential Revision: 201085
Reviewed By: adonohue
Reviewers: adonohue
CC: adonohue
Revert Plan:
OK
2011-01-13 13:40:09 -08:00
epriestley
8c73ed915d
Fix a typo ish.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-12 17:20:45 -08:00
epriestley
3f13e36182
Update arcanist to use the PhutilSymbolLoader.
...
Summary: This should also fix the bug with double help for certain commands
Test Plan:
Reviewers:
CC:
2011-01-12 16:02:28 -08:00
epriestley
c8b303bc90
Add SVN pre-commit hook support.
...
Summary: Basic support for an SVN pre-commit hook. Still very skeletal.
Test Plan:
Reviewers:
CC:
2011-01-12 03:02:05 -08:00
epriestley
7d36705215
Ship unresolved unit test information to Differential.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-01-11 22:37:06 -08:00
epriestley
bb7e649fa5
Ship lint warnings to Differential.
...
Summary: Send skipped lint warnings to Differential. This also fixes a nasty
bug with lint excluding too many warnings based on line changes.
Test Plan: meta
Reviewers:
CC:
Differential Revision: 200387
2011-01-11 20:45:36 -08:00
epriestley
964630facc
Integrate with file.upload over conduit to ship binary changes to Differential.
...
Summary: support binary upload in the new arc so we can show image diffs, e.g.
Test Plan:
Reviewers:
CC:
2011-01-11 15:39:40 -08:00
epriestley
e508504ddf
Fix an issue in Subversion with a root working copy which is actually a symlink.
...
Summary: lol svn lol
Test Plan:
Reviewers:
CC:
2011-01-11 14:26:21 -08:00
epriestley
b7ccb78ece
Work around an issue with older diffs in the Facebook database.
...
Summary: We have some diffs which predate property tracking and are shipping
down sketch data, work around it in the client for now.
Test Plan:
Reviewers:
CC:
2011-01-10 14:15:08 -08:00
epriestley
9e77d3b3ba
Add --never-apply-patches and --apply-patches to lint.
...
Summary: These flags let you force the behavior of 'arc lint' instead of
prompting. Also made the amend behavior default to false since I've screwed
this up about 300 times in the mere hours I've been using git as a primary VCS.
Test Plan: ran arc lint with these flags
Reviewers:
CC:
2011-01-10 14:04:51 -08:00
epriestley
f071a55266
Avoid path change collision issue when diffing an unusual edge case out of
...
svn.
Summary: when you "svn cp" with a revision, we end up with some path collision
problems. This isn't a complete fix but it gets the change to Differential,
at least.
Test Plan:
Reviewers:
CC:
2011-01-10 12:41:58 -08:00
epriestley
10b0a553b4
Improve phutil module linter behavior for vanished modules and missing or
...
broken __init__.php.
Summary: This allows phutilmodulelinter to generate missing __init__.php and
recover from missing modules without horrible fataltown.
Test Plan:
Reviewers:
CC:
2011-01-10 00:07:58 -08:00
epriestley
12f1ba1d77
Remove XHPAST from arcanist.
...
Summary: see corresponding commit in libphutil
Test Plan: linted and analyzed both libraries, got more sensible build behavior
Reviewers:
CC:
2011-01-09 22:13:30 -08:00
epriestley
7d54ecb885
Provide a git commit template.
...
Summary: adds a Differential-suitable git commit template.
Test Plan: meta
Reviewers:
CC:
2011-01-09 20:42:37 -08:00
epriestley
efb8219196
Fix some problems with the module linter that would cause various conflicting
...
warnings raised in __init__.php to overwrite eachother in uncomfortable ways.
2011-01-09 20:40:31 -08:00
epriestley
2c235bdf38
Fix a couple of lint issues, and update to version 2 (github).
2011-01-09 15:51:04 -08:00
epriestley
2e73916fa2
Initial commit.
2011-01-09 15:22:25 -08:00
