3 commits

Author	SHA1	Message	Date
Austin McKinley	5d0f5afca8	Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map ... Summary: Fixes T12555. Test Plan: Added this class to the codebase and ran `arc liberate`: ``` <?php class FooBar { public static function doTheFoo() { return 'foobar'; } } ``` Ran `arc lint` and observed this warning: ``` Warning (XHP87) Class Not `abstract` Or `final` This class is neither `final` nor `abstract`, and does not have a docblock marking it `@concrete-extensible`. 1 <?php 2 >>> 3 class FooBar { 4 public static function doTheFoo() { 5 return "foobar"; 6 } ``` Added a `final` modifier to `FooBar`'s declaration and observed the warning went away. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T12555 Differential Revision: https://secure.phabricator.com/D17787	2017-04-25 10:58:21 -07:00
Joshua Spence	9dd6eafb52	Fold ArcanistPhutilXHPASTLinter into ArcanistXHPASTLinter ... Summary: I've been thinking about this for a while... why not just fold `ArcanistPhutilXHPASTLinter` into `ArcanistXHPASTLinter`? Test Plan: `arc unit` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D13867	2015-11-13 07:08:40 +11:00
Joshua Spence	dd0deb2407	Add XHAST linter standards ... Summary: Ref T8742. As mentioned in D13512. This still needs some work, but looks roughly how I expect it to. Mainly, I want to move the standards stuff to the linter itself rather than the linter rule. I wanted to push this out for some initial feedback though. Test Plan: This still needs work. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin Maniphest Tasks: T8742 Differential Revision: https://secure.phabricator.com/D13942	2015-11-13 07:07:52 +11:00