revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-26 14:38:18 +01:00
Code Issues Releases Wiki Activity
958 commits 5 branches 7 tags 12 MiB
Commit graph

3 commits

Author SHA1 Message Date
vrana
03199df925 Lint dynamic string usage in parameters treated as safe 
Summary:
This disallows code like this:

  $cmd = 'ls';
  execx($cmd);

But I guess it's not that big deal?

Test Plan: Linted whole Arcanist and Phabricator codebases, most parts looks fixable.

Reviewers: epriestley

CC: nh, aran, Korvin

Differential Revision: https://secure.phabricator.com/D4794
 2013-02-02 16:26:52 -08:00
vrana
3f747be644 Move isConstantString() to base class 
Summary: This can be useful by itself, we want to use it in FB linter.

Test Plan: This diff.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4744
 2013-01-30 12:56:59 -08:00
vrana
5aa3bc6ec0 Separate Phutil specific lint rules from XHPAST 
Summary: Also provides an example how to build custom linter using XHPAST.

Test Plan: Added debug output to `willLintPaths()`, verified that each path is parsed only once.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4718
 2013-01-29 10:54:40 -08:00