vrana
67c772d919
Warn about PHP 5.3 only functions and parameters
...
Test Plan:
Linted:
json_decode('{}', true, 1, 1);
gethostname();
Also linted all Phabricator repositories and found no occurrence.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1158
Differential Revision: https://secure.phabricator.com/D2806
2012-06-22 15:52:10 -07:00
vrana
a9dbb937e8
Warn about pht() with non constant string
...
Summary: We will extract them at some point, lint before it's too late.
Test Plan:
New test.
Linted all callsites.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2825
2012-06-21 18:07:13 -07:00
epriestley
7c3c1e88bd
Add test for "static::" to the PHP 5.3 linter
...
Summary: See https://github.com/facebook/phabricator/issues/133 .
Test Plan: Unit tests.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T1158
Differential Revision: https://secure.phabricator.com/D2778
2012-06-17 09:01:47 -07:00
vrana
0b45ec30be
Move files in Arcanist one level up
...
Summary:
- `kill_init.php`
- Manually change library map.
- Manually rename `/data/` test dirs.
- [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/`
- `arc liberate`
Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Koolvin
Maniphest Tasks: T1103
Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 11:56:00 -07:00
