1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-07-22 20:06:16 +02:00
phorge-arcanist/src
Andre Klapper 84210cedc6 Declare missing class properties in ArcanistDownloadWorkflow
Summary:
rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties `$id`, `$saveAs`, `$show`.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in `didParseArguments()`.

Test Plan: Run PHPStan static code analysis; grep the code in this class.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25713
2024-07-10 10:06:35 +02:00
..
__tests__ Catch more product names in "pht()", and replace newly matched Arcanist product names 2022-04-25 16:45:55 -07:00
browse Improve arc-browse for php 8.1 2023-07-07 09:16:59 -07:00
channel Move Phage to FuturePool 2020-04-05 05:56:21 -07:00
conduit Remove all product name literals in "pht()" in Arcanist 2022-04-25 12:21:31 -07:00
config Remove all product name literals in "pht()" in Arcanist 2022-04-25 12:21:31 -07:00
configuration Catch more product names in "pht()", and replace newly matched Arcanist product names 2022-04-25 16:45:55 -07:00
console Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
difference Fix an initialization issue in VectorTree 2020-05-04 15:50:26 -07:00
differential Catch more product names in "pht()", and replace newly matched Arcanist product names 2022-04-25 16:45:55 -07:00
docs Update Diviner documentation to reference Phorge instead of Phabricator for Arcanist. 2021-06-19 18:46:39 -06:00
engine Implement "arc work", to replace "arc feature" 2020-06-08 16:27:27 -07:00
error PhutilErrorHandler: support multiple error listeners 2023-11-27 20:32:12 +02:00
events Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
exception Provide some "preg_*" wrappers which raise exceptions on failure 2021-02-19 11:16:09 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
filesystem T15064: Several arcanist PHP 8.1 compat issues on Windows 2024-02-06 06:56:39 -05:00
future Declare missing class properties 2024-07-03 09:05:34 +02:00
hardpoint Fix additional "xsprintf()"-family static parameter errors 2020-09-08 11:45:54 -07:00
hgdaemon Fix a property name collision in ArcanistHgServerChannel 2017-02-16 05:44:10 -08:00
init Replace all phurl.io short URIs with target URIs 2024-02-28 14:59:26 +01:00
inspector Support inspection of remote refs with "arc inspect remote(...)" 2020-06-30 13:07:25 -07:00
internationalization Add fallback languages for locale files 2024-06-21 13:10:22 -04:00
ip Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
land Update other usages of "hg rebase" to use the new extension-enabling function 2021-07-21 17:11:25 -04:00
lexer Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
lint Fix ArcanistExternalLinter on Windows 2023-12-04 22:44:29 +01:00
log Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
moduleutils Correct PHPDoc of dropSymbolCache() 2024-07-10 10:06:03 +02:00
object Correct some Arcanist behaviors under PHP8.1 2021-12-09 13:44:31 -08:00
parser Correct manual upload of Differential patch with a leading BOM 2024-01-13 22:05:47 +01:00
phage Allow "phage" to print execution status on SIGINT 2020-04-06 11:09:43 -07:00
platform Rebrand: Add "path" entries to PlatformSymbols 2023-08-12 08:41:53 -07:00
progress Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
query Provide "gitsprintf(...)" and disambiguate Git ref selectors 2021-01-13 12:31:15 -08:00
readableserializer Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
ref Improve arc-browse for php 8.1 2023-07-07 09:16:59 -07:00
repository Fix arc diff in Subversion for non-English languages 2024-07-08 10:03:32 +02:00
runtime Replace all phurl.io short URIs with target URIs 2024-02-28 14:59:26 +01:00
serviceprofiler Provide additional Arcanist PHP 8.1 fixes 2021-12-09 16:42:19 -08:00
symbols Arc liberate: support traits 2024-03-15 19:58:41 +02:00
toolset Fix call to non-existing ArcanistAliasEffect::EFFECT_CONFIGURATION in ArcanistAliasEngine 2024-06-23 10:03:01 +02:00
unit Update PhpunitTestEngine.php and ArcanistPhpunitTestResultParser.php to use junit output rather than json. 2024-03-15 16:09:16 +00:00
upload Mostly remove "STDERR" and "STDOUT" constants from Arcanist 2022-05-03 11:58:45 -07:00
utils Improve PHPDoc of id() 2024-04-15 16:39:21 +02:00
work Update "arc land" display of build failures, and rename "DisplayRef" to "RefView" 2020-06-30 06:27:56 -07:00
workflow Declare missing class properties in ArcanistDownloadWorkflow 2024-07-10 10:06:35 +02:00
workingcopy Declare missing class properties 2024-07-03 09:05:34 +02:00
workingcopyidentity T15064: Several arcanist PHP 8.1 compat issues on Windows 2024-02-06 06:56:39 -05:00
xsprintf Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch 2023-05-09 08:29:00 +02:00
__phutil_library_init__.php Fully merge "libphutil/" into "arcanist/" 2020-02-12 15:17:38 -08:00
__phutil_library_map__.php Add "pht_list()", a translation wrapper for lists of items 2022-05-12 10:57:39 -07:00