mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-30 10:42:41 +01:00
cd17e84412
Summary: Reported at the phorge project (https://we.phorge.it/D25017), running `arc liberate` fails on PHP 8 due to the `log()` function using `fwrite()` incorrectly assuming a format pattern can be used. This updates to remove most of these status messages are they are largely uninformative and instead we can report progress. - Remove the `--quiet` argument - Always display the progress - Remove all informational/status log statements Test Plan: Tested using both PHP 7.3 and PHP 8: 1. I ran `arc liberate` and saw the standard output: ```lang=console SCAN Searching for libraries in the current working directory... WORK Updating library: src/ Done. DONE Updated library. ``` 2. I ran deleted `phabricator/src/.phutil_module_cache` and ran `arc liberate /src`, verifying that progress was displayed while the map was computed. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D21718
73 lines
1.7 KiB
PHP
Executable file
73 lines
1.7 KiB
PHP
Executable file
#!/usr/bin/env php
|
|
<?php
|
|
|
|
$root = dirname(dirname(dirname(__FILE__)));
|
|
require_once $root.'/support/init/init-script.php';
|
|
|
|
$args = new PhutilArgumentParser($argv);
|
|
$args->setTagline(pht('rebuild the library map file'));
|
|
$args->setSynopsis(<<<EOHELP
|
|
**rebuild-map.php** [__options__] __root__
|
|
Rebuild the library map file for a libphutil library.
|
|
|
|
EOHELP
|
|
);
|
|
|
|
$args->parseStandardArguments();
|
|
$args->parse(
|
|
array(
|
|
array(
|
|
'name' => 'drop-cache',
|
|
'help' => pht(
|
|
'Drop the symbol cache and rebuild the entire map from scratch.'),
|
|
),
|
|
array(
|
|
'name' => 'limit',
|
|
'param' => 'N',
|
|
'default' => 8,
|
|
'help' => pht(
|
|
'Controls the number of symbol mapper subprocesses run at once. '.
|
|
'Defaults to 8.'),
|
|
),
|
|
array(
|
|
'name' => 'show',
|
|
'help' => pht(
|
|
'Print symbol map to stdout instead of writing it to the map file.'),
|
|
),
|
|
array(
|
|
'name' => 'ugly',
|
|
'help' => pht(
|
|
'Use faster but less readable serialization for "--show".'),
|
|
),
|
|
array(
|
|
'name' => 'root',
|
|
'wildcard' => true,
|
|
),
|
|
));
|
|
|
|
$root = $args->getArg('root');
|
|
if (count($root) !== 1) {
|
|
throw new Exception(pht('Provide exactly one library root!'));
|
|
}
|
|
$root = Filesystem::resolvePath(head($root));
|
|
|
|
$builder = new PhutilLibraryMapBuilder($root);
|
|
$builder->setSubprocessLimit($args->getArg('limit'));
|
|
|
|
if ($args->getArg('drop-cache')) {
|
|
$builder->dropSymbolCache();
|
|
}
|
|
|
|
if ($args->getArg('show')) {
|
|
$library_map = $builder->buildMap();
|
|
|
|
if ($args->getArg('ugly')) {
|
|
echo json_encode($library_map);
|
|
} else {
|
|
echo id(new PhutilJSON())->encodeFormatted($library_map);
|
|
}
|
|
} else {
|
|
$builder->buildAndWriteMap();
|
|
}
|
|
|
|
exit(0);
|