mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-02 03:32:41 +01:00
b61e4eacf1
revision is the correct base revision relative to the patch. Summary: What the title says. If not correct, warn the user. This check honors the --force flag to skip all these checks. This change also includes moving some Differential constants into Arc so they can be used for both projects. There is a corresponding phabricator diff (incoming) to address this part of the change. Test Plan: For a project with actual diffs, a git repository tracked by phabricator, *AND* development in master branch only, do some... - git reset --hard HEAD^1 - arc patch DX, where X is what got us to HEAD in the first place - verify successful patch ...then... - git reset --hard HEAD^^ - arc patch DX, where X is what got us to HEAD in the first place - verify warning - verify Y versus N continues versus stops appropriately Note if development were done outside the master branch this warning message will fire early / often as git commit hashes are based on the commit *and* the rest of the source code the commit is made against. This is (unfortunately) the "typical" case so this warning is pretty active at the moment. T201 will eventually land and when parsing a given commit update the corresponding diff. Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Differential Revision: https://secure.phabricator.com/D1328 |
||
---|---|---|
.. | ||
__init__.php | ||
ArcanistSubversionAPI.php |