mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-03 04:02:42 +01:00
0cb1b7efad
Summary: Previously, running arc lint on a set of changes that only existed in your working copy threw an exception in mercurial repos. It was trying to use the revset "...." (i.e. the range from . to .), which didn't parse. Even if I fix that it still doesn't work because getRawDiffText did not include the working copy changes (which it does in git). I removed the check so the function now acts the same as in git and arc lint works on working copy changes. I've seen this error before in other places so hopefully this change will also fix any other areas, that depended on getRawDiffText working the same as git. The logic I removed was added in D1954 to support diffing against uncommited changes. That workflow should be unchanged. arc diff will still prompt the user if there are uncommited changes, and the user can still choose to abort or continue. Let me know if I missed something important which makes this a bad idea. Test Plan: Edited a file in the working directory of a hg repo. arc lint Verified lint ran successfully. Also ran arc diff and land with and without working copy changes to make sure they still work. I'd kill for some tests in this area... Reviewers: epriestley, vrana Reviewed By: epriestley CC: dschleimer, bos, sid0, aran, Korvin Maniphest Tasks: T1631 Differential Revision: https://secure.phabricator.com/D5130 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| ArcanistGitAPI.php | ||
| ArcanistMercurialAPI.php | ||
| ArcanistRepositoryAPI.php | ||
| ArcanistSubversionAPI.php | ||