revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/workflow
History
epriestley 11e2c1688f Fix escaping of bookmarknames properly for arc patch 
Summary:
Fixes T4596. I misunderstood this issue and D8512 was not correct. Specifically:

  - The `hg log` needs to be escaped, since otherwise "arcpatch-x" is interpreted as a revset.
  - The `hg update` does not need to be escaped, since updating to a revset doesn't make sense and the command never treats its argument as a revset.
  - The `hg bookmark` does not need to be escaped, for similar reasons.

Test Plan:
  - Ran these commands in isolation and got sensible, consistent results.
  - Ran `arc patch` several times in a row and got proper bookmark names.

Reviewers: btrahan, durham, rvanvelzen

Reviewed By: rvanvelzen

Subscribers: epriestley

Maniphest Tasks: T4596

Differential Revision: https://secure.phabricator.com/D8661
2014-04-01 08:21:15 -07:00
..
exception Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistAliasWorkflow.php Extract configuration read/write methods out of BaseWorlkflow 2013-10-18 16:10:45 -07:00
ArcanistAmendWorkflow.php Don't close revisions on "arc amend" 2014-03-13 18:00:20 -07:00
ArcanistAnoidWorkflow.php Fix dynamic string usage as safe input 2013-02-02 16:28:15 -08:00
ArcanistBackoutWorkflow.php Added ArcanistTextLinter::LINT_BOF_WHITESPACE and ArcanistTextLinter::LINT_EOF_WHITESPACE 2014-01-13 18:05:42 -08:00
ArcanistBaseWorkflow.php Detect repo for 'browse'; don't require project ID 2014-02-09 08:55:16 -08:00
ArcanistBookmarkWorkflow.php Support arc bookmark in Mercurial 2013-02-13 13:58:07 -08:00
ArcanistBranchWorkflow.php Support arc bookmark in Mercurial 2013-02-13 13:58:07 -08:00
ArcanistBrowseWorkflow.php Minor modernizations to arc browse 2014-02-09 12:19:57 -08:00
ArcanistCallConduitWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistCloseRevisionWorkflow.php Use more modern detection of repositories in "arc close-revision" 2014-03-13 18:01:53 -07:00
ArcanistCloseWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistCommitWorkflow.php fixes local svn branch name detection 2013-08-13 14:16:14 -07:00
ArcanistCoverWorkflow.php Refactor commit ranges and base commit handling 2012-12-17 12:54:08 -08:00
ArcanistDiffWorkflow.php Strip comments during arc diff --verbatim workflow before submitting to Phabricator 2014-04-01 08:21:05 -07:00
ArcanistDownloadWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistExportWorkflow.php Don't use emailuser in Mercurial 2013-04-02 14:06:46 -07:00
ArcanistFeatureWorkflow.php Add output-json option to arc feature 2013-11-25 11:50:11 -08:00
ArcanistFlagWorkflow.php Apply new whitespace lint rules to arcanist/ 2013-02-19 14:09:20 -08:00
ArcanistGetConfigWorkflow.php rename getConfig -> getProjectConfig, make all linters use getConfigFromAnySource 2013-10-22 15:34:06 -07:00
ArcanistGitHookPreReceiveWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistHelpWorkflow.php Specify custom arcrc filename 2013-10-25 15:57:38 -07:00
ArcanistInlinesWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistInstallCertificateWorkflow.php Extract configuration read/write methods out of BaseWorlkflow 2013-10-18 16:10:45 -07:00
ArcanistLandWorkflow.php Arcanist - add revision data to TYPE_LAND_WILLPUSHREVISION event 2014-03-11 15:21:46 -07:00
ArcanistLiberateWorkflow.php Update some output based on flag being set 2013-06-25 15:26:14 -07:00
ArcanistLintWorkflow.php Provide ConfigurationManager to LintEngine in Arcanist 2013-10-21 16:57:22 -07:00
ArcanistListWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistMarkCommittedWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistPasteWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistPatchWorkflow.php Fix escaping of bookmarknames properly for arc patch 2014-04-01 08:21:15 -07:00
ArcanistRevertWorkflow.php Added ArcanistTextLinter::LINT_BOF_WHITESPACE and ArcanistTextLinter::LINT_EOF_WHITESPACE 2014-01-13 18:05:42 -08:00
ArcanistSetConfigWorkflow.php Show current config and source using arc set-config --show 2014-01-02 12:09:03 -08:00
ArcanistShellCompleteWorkflow.php fix tab complete for out-of-workdir 2014-03-25 17:33:23 -07:00
ArcanistSvnHookPreCommitWorkflow.php Lint engine seems to get null configuration manager in svn precommit hook workflow 2014-03-11 15:35:28 -07:00
ArcanistTasksWorkflow.php Use user.query, not user.find, in arc tasks 2014-01-25 14:23:23 -08:00
ArcanistTodoWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistUnitWorkflow.php get Config Manager to Unit engine and use getConfigFromAnySource 2013-10-22 13:58:32 -07:00
ArcanistUpgradeWorkflow.php Minor, fix a typo. 2013-10-18 16:19:22 -07:00
ArcanistUploadWorkflow.php Delete license headers from files 2012-11-05 11:16:24 -08:00
ArcanistWhichWorkflow.php Allow arc to identify repositories without "project_id" 2014-01-26 15:31:30 -08:00