1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-22 21:40:54 +01:00
phorge-arcanist/support
Christopher Speck cd17e84412 Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to adjust it
Summary:
Reported at the phorge project (https://we.phorge.it/D25017), running `arc liberate` fails on PHP 8 due to the `log()` function using `fwrite()` incorrectly assuming a format pattern can be used.

This updates to remove most of these status messages are they are largely uninformative and instead we can report progress.
- Remove the `--quiet` argument
- Always display the progress
- Remove all informational/status log statements

Test Plan:
Tested using both PHP 7.3 and PHP 8:
1. I ran `arc liberate` and saw the standard output:
```lang=console
 SCAN  Searching for libraries in the current working directory...
 WORK  Updating library: src/
Done.
 DONE  Updated library.
```
2. I ran deleted `phabricator/src/.phutil_module_cache` and ran `arc liberate /src`, verifying that progress was displayed while the map was computed.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D21718
2021-09-04 21:22:23 -04:00
..
arcanoid Correct an issue when winning "arc anoid" with certain terminal dimensions 2021-05-31 23:10:36 -07:00
hg Update "arc diff" to amend non-head commits with Mercurial 2021-07-20 16:55:27 -04:00
init Apply "pcre.*_limit" config options at startup in CLI environments 2021-02-19 11:16:09 -08:00
lib Update "arc liberate" to fix error with PHP 8 and add "--verbose" argument to adjust it 2021-09-04 21:22:23 -04:00
shell Port "arc prompts" from wilds and fix a path issue in shell completion 2020-04-11 10:43:05 -07:00
unit Merge utility/support changes from "wilds" to "master" 2020-02-13 14:10:09 -08:00
xhpast Fix improper XHPAST parsing of namespace grammar like "use x as private;" 2020-04-07 14:35:42 -07:00