1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 14:00:55 +01:00
No description
Find a file
epriestley 13ea6ea5b6 Add basic binary file support to 'arc patch'
Summary:
I'm probably missing some edge cases but it took me almost 3 hours to get this
far and I think it only makes things work that didn't work before. Some stuff
like SVN binary patches still won't work, although they should be far easier to
implement.

Most of the magic here just comes from reading the git source code. It appears
to work correctly; I sprinkled printf() around git liberally and recompiled it
during development. Took me about 45 minutes to figure out that "Index" vs
"index" causes git to silently fail in a confusing way. :/

Git has a diff mode for binary changes but I don't think we lose much by always
using the full binaries. We can enhance it later if we want.

Test Plan:
Exported and patched binary changes (a picture of a duck) into a working copy.

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: simpkins, aran, epriestley
Differential Revision: 327
2011-05-22 06:58:16 -07:00
bin Initial commit. 2011-01-09 15:22:25 -08:00
externals arc lint: fix/enable PEP8 linter 2011-05-18 16:47:23 -07:00
resources Basic 'shell-complete' workflow. 2011-01-17 20:18:27 -08:00
scripts Detect library conflicts in Arcanist and raise a very specific error message 2011-05-19 11:32:53 -07:00
src Add basic binary file support to 'arc patch' 2011-05-22 06:58:16 -07:00
.arcconfig Detect library conflicts in Arcanist and raise a very specific error message 2011-05-19 11:32:53 -07:00
.divinerconfig Updated .divinerconfig. 2011-03-02 15:25:45 -08:00
.gitignore Basic doc config for arcanist. 2011-02-09 17:06:24 -08:00
LICENSE Initial commit. 2011-01-09 15:22:25 -08:00
README Initial commit. 2011-01-09 15:22:25 -08:00

PROJECT STATUS: CAVEAT EMPTOR

This is an unstable preview release. I'm open sourcing some of Facebook's
internal tools, but they'll be unstable for at least a couple months.
-epriestley


WHAT IS ARCANIST?

Arcanist is the CLI for Facebook's code review tool, Differential. Since
Differential isn't released yet, it may not be terribly useful on its own.