phorge-arcanist/src/lint/renderer/__tests__/data/addlinesuffix.txt at 17515c94b2dabd4b6e3d20101b479d927c62b88e - revi-archive/phorge-arcanist - SiliconForest Atelier

revi-archive/phorge-arcanist

mirror of https://we.phorge.it/source/arcanist.git synced 2025-03-13 04:44:53 +01:00

epriestley 86779b1526 Render lint patches which have newlines in a less misleading way

Summary:
Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  - Includes test coverage for removing a newline, from T12765.
  - Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  - For one-line patches, highlighting the patched section.
  - For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan: Ran unit tests, linted a few things.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9846

Differential Revision: https://secure.phabricator.com/D18510

2017-08-31 13:28:31 -07:00

5 lines

30 B

Text

Raw Blame History

 apple
 banana
 date
 eclaire
 fig