revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-09 22:31:02 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/lint/linter
History
epriestley 1d3266395f Remove two problematic XML linter unit tests 
Summary:
Fixes T7215. See D13991. These test cases have been failing intermittently for a while.

I think the XML stuff (which we don't control) changed where it raises these warnings: an old version raised them at the end of the attribute, while the new version raises them at the beginning of the attribute. Not totally 100% sure about this since installing multiple versions is fairly inconvenient, but as far as I know both versions raise the warnings, just at different character offsets.

We could do various things to fix these tests (allow the warning to raise at any character, skip the tests based on versions, etc) but I think it's easier to just remove the tests. They don't seem valuable.

Test Plan: Tests failed prior to change; now pass.

Reviewers: chad, joshuaspence

Reviewed By: joshuaspence

Maniphest Tasks: T7215

Differential Revision: https://secure.phabricator.com/D13992
2015-08-24 21:07:28 -07:00
..
__tests__ Remove two problematic XML linter unit tests 2015-08-24 21:07:28 -07:00
exception Move linter exception classes to src/lint/linter/exception 2015-01-12 06:46:23 +11:00
xhpast Exclude variables used in strings inside closures when checking for undeclared variables 2015-08-21 07:26:52 +10:00
ArcanistBaseXHPASTLinter.php Split the ArcanistXHPASTLinter into modular rules 2015-06-01 15:49:16 +10:00
ArcanistChmodLinter.php Add unit tests for ArcanistChmodLinter 2015-01-15 06:58:11 +11:00
ArcanistClosureLinter.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
ArcanistCoffeeLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistComposerLinter.php Add a Composer linter 2015-08-19 21:39:11 +10:00
ArcanistCppcheckLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistCpplintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistCSharpLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistCSSLintLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistExternalLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistFilenameLinter.php Fix visibility of various ArcanistLinter methods 2015-01-07 07:36:07 +11:00
ArcanistFlake8Linter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistFutureLinter.php Split large path lists into blocks when linting 2015-04-22 05:15:57 -07:00
ArcanistGeneratedLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistGoLintLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistHLintLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistInlineHTMLXHPASTLinterRule.php Improve the "inline HTML" linter rule 2015-08-19 15:34:43 +10:00
ArcanistJscsLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistJSHintLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistJSONLinter.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
ArcanistJSONLintLinter.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
ArcanistLesscLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistLinter.php Extend from Phobject 2015-06-15 15:47:33 +10:00
ArcanistMergeConflictLinter.php Minor reordering of functions 2014-09-22 18:42:41 +10:00
ArcanistNoLintLinter.php Remove severity options from some linters. 2014-05-11 19:28:27 -07:00
ArcanistPEP8Linter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPhpcsLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistPhpLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistPhutilLibraryLinter.php phtize a bunch more strings 2015-05-22 17:09:56 +10:00
ArcanistPhutilXHPASTLinter.php Add a linter rule for extending Phobject 2015-06-15 15:44:45 +10:00
ArcanistPuppetLintLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPyFlakesLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistPyLintLinter.php ArcanistPyLintLinter fix to getMandatoryFlags msg-template 2015-08-19 05:46:04 -07:00
ArcanistRuboCopLinter.php pht all the things 2015-05-13 21:00:53 +10:00
ArcanistRubyLinter.php Improve behavior for detecting the failure to parse external linter output 2015-05-22 07:30:17 +10:00
ArcanistScriptAndRegexLinter.php Remove deprecated linter configuration 2015-05-21 07:01:37 +10:00
ArcanistSpellingLinter.php Provide a getProjectRoot method for ArcanistLinter 2015-05-20 09:16:36 +10:00
ArcanistTextLinter.php Move LINT_NO_COMMIT from ArcanistTextLinter to a new linter 2015-01-04 16:20:32 +11:00
ArcanistXHPASTLinter.php Fix self member reference rule for PHP 5.3 2015-08-11 06:49:55 +10:00
ArcanistXMLLinter.php pht all the things 2015-05-13 21:00:53 +10:00
reporter.js Don't use error context from JSHint in linter messages 2014-06-23 10:33:01 +10:00