phorge-arcanist/src/parser/diff/__tests__/data/basic-missing-both-newlines-plus.udiff at 1da98a11f1f9e1390ab3f587cd67cea2a02c8ae9 - revi-archive/phorge-arcanist - SiliconForest Atelier

revi-archive/phorge-arcanist

mirror of https://we.phorge.it/source/arcanist.git synced 2025-03-31 06:28:12 +02:00

epriestley 1da98a11f1 Correctly parse git diffs with an empty file at the end

Summary: A minor bug in the parser prevented it from handling git diffs where an
empty file appears at the end of the diff. Since git appends an extra newline,
we failed to jump into the '$line === null' block.

Test Plan: Ran unit tests. Generated a revision which only deleted an empty
file.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: nh

CC: aran, nh, epriestley

Differential Revision: 998

2011-10-10 19:03:48 -07:00

12 lines

278 B

Text

Raw Blame History

 --- a	2010-03-03 09:51:59.000000000 -0800
 +++ b	2010-03-03 09:52:03.000000000 -0800
@@ -1 +1 @@
 -a
 \ No newline at end of file
 +b
 \ No newline at end of file
 --- empty	2010-03-03 09:52:29.000000000 -0800
 +++ full	2010-03-03 09:52:45.000000000 -0800
@@ -0,0 +1,2 @@
 +duck
 +quack