mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-04-06 01:18:23 +02:00
1da98a11f1
Summary: A minor bug in the parser prevented it from handling git diffs where an empty file appears at the end of the diff. Since git appends an extra newline, we failed to jump into the '$line === null' block. Test Plan: Ran unit tests. Generated a revision which only deleted an empty file. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh, epriestley Differential Revision: 998
19 lines
571 B
Text
19 lines
571 B
Text
commit 501f6d519703458471dbea6284ec5f49d1408598
|
|
Merge: f3d9834 e4b5d09
|
|
Author: Hans Fugal <fugalh@facebook.com>
|
|
Date: 21 hours ago
|
|
|
|
fbi.have_debug() to disappear
|
|
|
|
Summary:
|
|
fbi.have_debug() is boring because libfbi has no --enable-debug-log
|
|
option - the only question is whether the debugging will do anything (if
|
|
libasox or libmc has --enable-debug-log). So it always returns true. It
|
|
will probably go away, and this is the change to go with that.
|
|
|
|
Test Plan:
|
|
python test/test.py -d 1
|
|
|
|
Reviewers: marc, larry
|
|
Tags: libmc,libfbi
|
|
|