mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-12-23 14:00:55 +01:00
1daa719ace
Summary: Fixes T4349. Two issues: - As discussed in T4349, we would trim the entire output and then require spaces when matching. This choked incorrectly if the last line of a file contained only whitespace. Use `phutil_split_lines()` instead, and regexp things more reasonably. - We were capturing the line text, not the commit, as "revision". This isn't actually used elsewhere, but was obviously wrong. Make this consistent with Git/SVN. Test Plan: Rigged a call up and saw reasonable output after the patch, on a working copy which threw before the patch. Reviewers: durham, btrahan Reviewed By: durham CC: aran Maniphest Tasks: T4349 Differential Revision: https://secure.phabricator.com/D8078 |
||
|---|---|---|
| .. | ||
| configuration | ||
| difference | ||
| differential | ||
| docs | ||
| events/constant | ||
| exception | ||
| extensions | ||
| hgdaemon | ||
| infrastructure/testing | ||
| lint | ||
| parser | ||
| repository | ||
| unit | ||
| workflow | ||
| workingcopyidentity | ||
| __phutil_library_init__.php | ||
| __phutil_library_map__.php | ||