1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-10-24 01:28:51 +02:00
phorge-arcanist/src
epriestley 1daa719ace Don't choke on blame of files with whitespace-only trailing lines
Summary:
Fixes T4349. Two issues:

  - As discussed in T4349, we would trim the entire output and then require spaces when matching. This choked incorrectly if the last line of a file contained only whitespace. Use `phutil_split_lines()` instead, and regexp things more reasonably.
  - We were capturing the line text, not the commit, as "revision". This isn't actually used elsewhere, but was obviously wrong. Make this consistent with Git/SVN.

Test Plan: Rigged a call up and saw reasonable output after the patch, on a working copy which threw before the patch.

Reviewers: durham, btrahan

Reviewed By: durham

CC: aran

Maniphest Tasks: T4349

Differential Revision: https://secure.phabricator.com/D8078
2014-01-27 11:03:08 -08:00
..
configuration Allow arc to identify repositories without "project_id" 2014-01-26 15:31:30 -08:00
difference Compute UTF8 string differences correctly, accounting for combining characters 2013-05-23 14:38:09 -07:00
differential Arcanist - make Patch workflow automagically apply dependencies 2013-10-17 14:59:04 -07:00
docs Make the "this is technical documentation" message of "Arcanist Overview" more clear 2012-08-10 11:37:30 -07:00
events/constant Dispatch an event in arc land right before pushing a revision 2013-03-08 18:32:36 -08:00
exception Delete license headers from files 2012-11-05 11:16:24 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Fix dynamic string usage as safe input 2013-02-02 16:28:15 -08:00
infrastructure/testing Delete license headers from files 2012-11-05 11:16:24 -08:00
lint Call willLintPath() hook from PhutilLinter 2014-01-17 21:30:18 -08:00
parser Fix exception on diff parse on FreeBSD 2014-01-18 11:13:28 -08:00
repository Don't choke on blame of files with whitespace-only trailing lines 2014-01-27 11:03:08 -08:00
unit Added ArcanistTextLinter::LINT_BOF_WHITESPACE and ArcanistTextLinter::LINT_EOF_WHITESPACE 2014-01-13 18:05:42 -08:00
workflow Default to array() when failing to look up repository PHIDs. 2014-01-27 10:36:40 -08:00
workingcopyidentity Allow arc to identify repositories without "project_id" 2014-01-26 15:31:30 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Allow arc to identify repositories without "project_id" 2014-01-26 15:31:30 -08:00