1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
phorge-arcanist/src
epriestley 2198cc2849 Fix an issue with arc branch and very old branches
Summary:
In D9595, we stopped parsing short-form "Differential Revision:" fields in commit messages, and only accept URLs.

I have one of the older style commit messages in my local `arcanist/`, so now we go down this parse failure branch in `arc branch`. This has never worked quite correctly, and if the parse fails we end up with a bad branch dictionary that is missing fields.

Test Plan: Ran `arc branch` in a working copy with an old `Differential Revision:` field at the head of a branch. Before patch: explosions; after patch: works great.

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9620
2014-06-18 08:35:29 -07:00
..
__tests__ Add a unit test to check src/__phutil_library_map__.php. 2014-06-16 05:42:43 +10:00
configuration Allow specifying runtime configuration with --set-config key=value 2014-06-16 15:28:33 -07:00
difference Change double quotes to single quotes. 2014-05-23 13:53:05 -07:00
differential Drop support for parsing non-URL differential IDs from commit message. 2014-06-18 01:39:28 +10:00
docs/book Generate a documentation book for Arcanist 2014-03-05 13:00:40 -08:00
events/constant Dispatch an event in arc land right before pushing a revision 2013-03-08 18:32:36 -08:00
exception Delete license headers from files 2012-11-05 11:16:24 -08:00
extensions Changes to Arcanist for libphutil "extensions/" 2013-04-22 14:38:49 -07:00
hgdaemon Change double quotes to single quotes. 2014-05-23 13:53:05 -07:00
infrastructure/testing Delete license headers from files 2012-11-05 11:16:24 -08:00
lint Allow PHP version to be customized with ArcanistXHPASTLinter 2014-06-18 01:30:15 +10:00
parser --range support for git 2014-06-11 14:37:01 -07:00
repository Fix race condition inside git diff-files 2014-06-18 05:33:05 -07:00
unit Apply various linter fixes. 2014-06-10 11:02:42 -07:00
workflow Fix an issue with arc branch and very old branches 2014-06-18 08:35:29 -07:00
workingcopyidentity Remove the deprecated ArcanistWorkCopyIdentity::getConfig method. 2014-06-17 06:39:47 +10:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:24 -08:00
__phutil_library_map__.php Add an ArcanistJscsLinter. 2014-06-17 06:40:36 +10:00