mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
No description
2892c6ef1a
Summary: Keeping unit tests speedy keeps them useful since people actually won't mind running them. This diff records the time taken by each test and displays it nice and colorized. Really, I just want to discourage non-unit tests from making their way into ##__tests__##. Some thoughts: - The "acceptableness" times are subjective but if dependencies are properly mocked the times seem to be ok. Integration tests that make network requests to third-party endpoints and pull in megabytes of data will not survive. This is a good thing. - Fast tests get a gold star, encouraging small tests. I am sorry that the star does not sparkle. - There is no way for a programmer to admit that their test is going to be slow in some cases. They will be shamed with red text for the life of their test. - It might be confusing that fast but failing tests get green text and maybe a gold star. Test Plan: Ran some of the unit tests within Arcanist and libphutil. See https://secure.phabricator.com/file/view/PHID-FILE-cdd3c94c219e0fd7470b/ for sample output. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 588 |
||
|---|---|---|
| bin | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| LICENSE | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for at least a couple months. -epriestley WHAT IS ARCANIST? Arcanist is the CLI for Facebook's code review tool, Differential. Since Differential isn't released yet, it may not be terribly useful on its own.