mirror of
https://we.phorge.it/source/arcanist.git
synced 2025-02-03 18:38:26 +01:00
31ec011922
Summary: We have some git-specific logic on main pathways which should be in the API class, move it around so "arc lint" with an engine works under Mercurial. This resovles the error @makinde reported: > PHP Catchable fatal error: Argument 1 passed to ArcanistBaseWorkflow::parseGitRelativeCommit() must be an instance of ArcanistGitAPI, instance of ArcanistMercurialAPI given, called in /home/makinde/.arc_install/arcanist/src/workflow/lint/ArcanistLintWorkflow.php on line 131 and defined in /home/makinde/.arc_install/arcanist/src/workflow/base/ArcanistBaseWorkflow.php on line 830 Test Plan: Ran "arc diff" in git and hg working copies, plus "arc lint" with a configured "lint_engine". Reviewers: Makinde, aran, jungejason, nh, tuomaspelkonen Reviewed By: Makinde CC: aran, Makinde Differential Revision: 935 |
||
---|---|---|
.. | ||
__init__.php | ||
ArcanistLintWorkflow.php |