mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-21 22:32:41 +01:00
cd17e84412
Summary: Reported at the phorge project (https://we.phorge.it/D25017), running `arc liberate` fails on PHP 8 due to the `log()` function using `fwrite()` incorrectly assuming a format pattern can be used. This updates to remove most of these status messages are they are largely uninformative and instead we can report progress. - Remove the `--quiet` argument - Always display the progress - Remove all informational/status log statements Test Plan: Tested using both PHP 7.3 and PHP 8: 1. I ran `arc liberate` and saw the standard output: ```lang=console SCAN Searching for libraries in the current working directory... WORK Updating library: src/ Done. DONE Updated library. ``` 2. I ran deleted `phabricator/src/.phutil_module_cache` and ran `arc liberate /src`, verifying that progress was displayed while the map was computed. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D21718 |
||
---|---|---|
.. | ||
arcanoid | ||
hg | ||
init | ||
lib | ||
shell | ||
unit | ||
xhpast |